New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert lock row fix during migration #4865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
OlivierCavadenti
commented
Nov 30, 2021
- Problem : During migration, the _insertLockRowIfNeeded function try to make select statement without FROM clause. That works in some db but no in Oracle and MariaDB (you need to use DUAL).
- I rewrite the _insertLockRowIfNeeded to make it works in any db (no database specific logic)
- Closes Syntax error in your SQL generated by knex - Insert into migration_lock #4864 ORA-00923: FROM keyword not found where expected on migrate #4844 Unable to run migrations: table knex_migrations_lock is not created #4835
No test? |
OlivierCavadenti
force-pushed
the
lock-row-fix
branch
from
November 30, 2021 23:27
eaff595
to
f846ced
Compare
OlivierCavadenti
force-pushed
the
lock-row-fix
branch
from
November 30, 2021 23:35
e311cc0
to
aead58a
Compare
kibertoad
approved these changes
Nov 30, 2021
This was referenced Nov 30, 2021
@kibertoad do you think we can backport this in 0.95.15 ? |
Sure! |
OlivierCavadenti
added a commit
that referenced
this pull request
Dec 3, 2021
(cherry picked from commit 540ab8c)
OlivierCavadenti
added a commit
that referenced
this pull request
Dec 3, 2021
(cherry picked from commit 540ab8c)
Any time frame when this will release in a new version? 0.95.15? Kinda need this fix .. |
I'll try to do it asap this week |
I'm also interested in this fix ASAP :) |
@mica16 @HappyZombies Released in 0.95.15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.