Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix SQLite not doing rollback when altering columns fails (#4336)" #4896

Merged
merged 1 commit into from Dec 15, 2021
Merged

Revert "Fix SQLite not doing rollback when altering columns fails (#4336)" #4896

merged 1 commit into from Dec 15, 2021

Conversation

nickrum
Copy link
Contributor

@nickrum nickrum commented Dec 15, 2021

Reverts #4336.
Now that #4189 has been merged, we can safely revert this PR.

@nickrum
Revert "Fix SQLite not doing rollback when altering columns fails (kn…
16f3a78 
…ex#4336)"

Reverts knex#4336.
Now that knex#4189 has been merged, we can safely revert this PR.
@nickrum nickrum mentioned this pull request Dec 15, 2021
Merged
@kibertoad kibertoad merged commit e2a425e into knex:master Dec 15, 2021
@nickrum nickrum deleted the revert-sqlite-rollback-hotfix branch December 15, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickrum @kibertoad