Fix FOR UPDATE OF with explicit schema #5791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the _tableNames helper was written there were multiple methods
hitting it, but they've since been merged into the single _lockingClause
method. Given that the only really interesting thing it was doing was
prepending the schema name--which is the incorrect behavior this commit
fixes--it didn't seem worth keeping at this point.
I'm not sure you'd say `.withSchema('public')` in a real query but it
lets me exercise the behavior in question without having to learn enough
about knex's test environment to stand up a discrete schema. I suppose
it's plausible that a reasonable maintainer would go "hm that's silly
and redundant" and inadvertently remove coverage for this bug, though.
ErinCall
commented
Jan 19, 2024
| @@ -197,29 +197,12 @@ class QueryCompiler_PG extends QueryCompiler { | |||
| } | |||
| } | |||
|
|
|||
| // Join array of table names and apply default schema. | |||
| _tableNames(tables) { | |||
There was a problem hiding this comment.
When the _tableNames helper was written (#2835) there were multiple methods hitting it, but they've since been merged into the single _lockingClause method. Given that the only really interesting thing it was doing was prepending the schema name--which is the incorrect behavior this commit fixes--it didn't seem worth keeping at this point.
ErinCall
commented
Jan 19, 2024
| @@ -993,7 +993,7 @@ describe('Selects', function () { | |||
| try { | |||
| await knex.transaction((trx) => { | |||
| // select all from two test tables and lock only one table | |||
| return trx('test_default_table') | |||
| return trx.withSchema('public').from('test_default_table') | |||
There was a problem hiding this comment.
I'm not sure you'd say .withSchema('public') in a real query but it lets me exercise the behavior in question without having to learn enough about knex's test environment to stand up a discrete schema 😁
Turns out your changes only show up in git if you press "save" in your editor. Who knew!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
.withSchema(...)....forUpdate('someTable'), knex would produce incorrect sql syntax—it included the schema name in the table name, prompting a "FOR UPDATE must specify unqualified relation names" error from postgresql.Fixes #5053.