Missing comments on delete, update and insert for pg dialect #5793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisn
commented
Jan 25, 2024
There was a problem hiding this comment.
Humm.. Should I merge this file? Probably not.
atishhamte
suggested changes
Mar 1, 2024
| } | ||
|
|
||
| // is used if the an array with multiple empty values supplied | ||
|
|
||
| // Compiles an `insert` query, allowing for multiple | ||
| // inserts using a single query statement. | ||
| insert() { | ||
| let sql = super.insert(); | ||
| let sql = this.comments() + ' ' + super.insert(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 5738 pointed out that knex does not integrate comments in INSERT/UPDATE/DELETE .
The fix was coded for mysql and merged on Nov 27, 2023.
The present PR fixes the same issue for "pg" dialect.