Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "to_number(rownum)" to prevent ORA-01722 #6026

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Change "to_number(rownum)" to prevent ORA-01722 #6026

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55a7f50
Change "to_number(rownum)" to fix ORA-01722
S200124 Mar 7, 2024
adaee49
Merge branch 'master' into master
S200124 Mar 11, 2024
14ca6e1
Merge branch 'knex:master' into master
S200124 Apr 29, 2024
803b54a
Merge branch 'master' into master
S200124 May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/dialects/oracle/query/oracle-querycompiler.js
View file
Open in desktop
Expand Up @@ -316,7 +316,7 @@ class QueryCompiler_Oracle extends QueryCompiler {
query = query || '';

if (hasLimit && !offset) {
return `select * from (${query}) where rownum <= ${this._getValueOrParameterFromAttribute(
return `select * from (${query}) where to_number(rownum) <= ${this._getValueOrParameterFromAttribute(
'limit',
limit
)}`;
Expand All @@ -329,7 +329,7 @@ class QueryCompiler_Oracle extends QueryCompiler {
'(select row_.*, ROWNUM rownum_ from (' +
query +
') row_ ' +
'where rownum <= ' +
'where to_number(rownum) <= ' +
(this.single.skipBinding['offset']
? endRow
: this.client.parameter(endRow, this.builder, this.bindingsHolder)) +
Expand Down