Add NULLS NOT DISTINCT
#6054
Open
Add NULLS NOT DISTINCT
#6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR, please throw an error for other dialects when they try to use it |
|
Done! @rluvaton is it look well? |
rluvaton
reviewed
Apr 6, 2024
| ({ indexName, deferrable, predicate } = indexName); | ||
| ({ indexName, deferrable, predicate, nullsNotDistinct } = indexName); | ||
| } | ||
| if (nullsNotDistinct !== undefined) { |
There was a problem hiding this comment.
allow null as well
Suggested change
| if (nullsNotDistinct !== undefined) { | |
| if (nullsNotDistinct != null) { |
| ({ indexName, deferrable } = indexName); | ||
| ({ indexName, deferrable, nullsNotDistinct } = indexName); | ||
| } | ||
| if (nullsNotDistinct !== undefined) { |
There was a problem hiding this comment.
allow null as well
Suggested change
| if (nullsNotDistinct !== undefined) { | |
| if (nullsNotDistinct != null) { |
| } | ||
| if (deferrable && deferrable !== 'not deferrable') { | ||
| this.client.logger.warn( | ||
| `mysql: unique index \`${indexName}\` will not be deferrable ${deferrable} because mysql does not support deferred constraints.` | ||
| ); | ||
| } | ||
| if (nullsNotDistinct !== undefined) { |
There was a problem hiding this comment.
allow null as well
Suggested change
| if (nullsNotDistinct !== undefined) { | |
| if (nullsNotDistinct != null) { |
| @@ -298,6 +300,9 @@ class TableCompiler_MSSQL extends TableCompiler { | |||
| if (useConstraint && predicate) { | |||
| throw new Error('mssql cannot create constraint with predicate'); | |||
| } | |||
| if (nullsNotDistinct !== undefined) { | |||
There was a problem hiding this comment.
allow null as well
Suggested change
| if (nullsNotDistinct !== undefined) { | |
| if (nullsNotDistinct != null) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres 15+ allows to add
NULLS NOT DISTINCTfor unique indexes and constraints.I added
nullNotDistinct: booleanoption foruniqueinTableBuilder, to make possible to use this feature.https://www.postgresql.org/about/featurematrix/detail/392/