feat: prevent runtime problems

koajs · Apr 16, 2023 · ee10822 · ee10822
1 parent cf7ac14
commit ee10822
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/body-parser.utils.ts b/src/body-parser.utils.ts
@@ -43,10 +43,11 @@ export function getIsEnabledBodyAs(enableTypes: BodyType[]) {
 export function getMimeTypes(
   extendTypes: NonNullable<BodyParserOptions['extendTypes']>,
 ) {
-  for (const extendedType of Object.keys(extendTypes) as BodyType[]) {
+  for (const extendedType in extendTypes) {
     if (
-      !supportedBodyTypes.includes(extendedType) ||
-      !Array.isArray(extendTypes[extendedType])
+      !supportedBodyTypes.includes(extendedType as BodyType) ||
+      !Array.isArray(extendTypes[extendedType as BodyType]) ||
+      !extendTypes[extendedType as BodyType]?.filter(Boolean).length
     ) {
       throw new UnsupportedBodyTypeError(extendedType);
     }

diff --git a/test/middleware.test.ts b/test/middleware.test.ts
@@ -383,7 +383,7 @@ describe("test/body-parser.test.ts", () => {
       }
     });
 
-    it("should throw when pass supported type but with string value instead of array", () => {
+    it("should throw when pass supported types with string value instead of array", () => {
       try {
         createApp({
           extendTypes: {
@@ -394,6 +394,17 @@ describe("test/body-parser.test.ts", () => {
         expect(error instanceof UnsupportedBodyTypeError).toBe(true);
       }
     });
+    it("should throw when pass supported types with array contain falsy values", () => {
+      try {
+        createApp({
+          extendTypes: {
+            json: ["", 0, false, null, undefined],
+          } as any,
+        });
+      } catch (error) {
+        expect(error instanceof UnsupportedBodyTypeError).toBe(true);
+      }
+    });
   });
 
   describe("enableTypes", () => {