Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VERSION: update minimal version from 8 -> 12 #148

Closed
wants to merge 1 commit into from
Closed

VERSION: update minimal version from 8 -> 12 #148

wants to merge 1 commit into from

Conversation

etroynov
Copy link

Hi,

The minimal node.js version which is supported by koa right now is 12, for this reason, I think that this package should also be updated, I have prepared it PR for you :)

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@etroynov
Copy link
Author

@dead-horse can you check this PR?

@etroynov
Copy link
Author

@titanism what do you think about it?

@3imed-jaberi
Copy link
Member

Fixed through this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etroynov @3imed-jaberi