Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not override already set content-type, fixes #1120 #1131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fl0w
Copy link
Contributor

@fl0w fl0w commented Feb 2, 2018

semver major, #1114

This could be done as semver minor - if an application setting is addd, e.g. app.responsOverride = true or something.

@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #1131 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1131   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files           5        5           
  Lines         372      372           
=======================================
  Hits          371      371           
  Misses          1        1
Impacted Files Coverage Δ
lib/response.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a64e4ae...c7b620a. Read the comment docs.

@jonathanong
Copy link
Member

this might break apps if someone is relying on this behavior, so i would wait for semver major.

@jonathanong
Copy link
Member

unless we only set it to json if the type is not json-like

@fl0w
Copy link
Contributor Author

fl0w commented Feb 7, 2018

Yes, definitely semver-major.
Though with this PR, #1137, #1115 and a few more a v3 is already justified (IMO).

It would be nice to drop a v3 alpha, call out EOL for v1 (soon-ish?) and break the stigma of having to rewrite Koa to justify a major bump and add proper deprecations to v2 and v1.

@niftylettuce
Copy link
Contributor

I agree @fl0w

@jkomyno
Copy link

jkomyno commented Apr 2, 2019

Any news about this PR? @jonathanong

@jkomyno
Copy link

jkomyno commented Apr 16, 2021

Hi, it's been two years, any update on this PR?
@jonathanong @3imed-jaberi @dead-horse @dougwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants