Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support searchParams #1575

Closed
wants to merge 2 commits into from
Closed

Conversation

adaex
Copy link

@adaex adaex commented Aug 24, 2021

ref #1570 #1574

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1575 (8672a8a) into master (5ee832c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8672a8a differs from pull request most recent head 6e51a6c. Consider uploading reports for the commit 6e51a6c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1575   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           5        5           
  Lines         507      512    +5     
  Branches      142      144    +2     
=======================================
+ Hits          505      510    +5     
  Misses          2        2           
Impacted Files Coverage Δ
lib/context.js 100.00% <ø> (ø)
lib/request.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ee832c...6e51a6c. Read the comment docs.

@adaex adaex changed the title [WIP] feat: add support searchParams feat: add support searchParams Aug 26, 2021
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this PR over upgrade.

@miwnwski
Copy link
Member

miwnwski commented Jul 2, 2022

Since there's incompatible changes in master anyway I feel we should just rip this band-aid. Closing in favour of #1574.

@miwnwski miwnwski closed this Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants