Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify extensions #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

olsonpm
Copy link

@olsonpm olsonpm commented Dec 25, 2023

I had to look at the code for koa-send to find whether extensions required the period before. So I added an example in the readme here to clarify

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
    I spent a few minutes trying to find a way to lint without installing something locally. If you want contributers to lint via commitlint then I suggest installing it per their current documentation
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant