Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new line scroll bottom #59

Closed
wants to merge 1 commit into from
Closed

fix: new line scroll bottom #59

wants to merge 1 commit into from

Conversation

jefrydco
Copy link
Contributor

Sorry, I can't add a test because of jsdom/jsdom#1695. But here is the result

vue-prism

Fix #1

@jefrydco jefrydco requested a review from koca February 11, 2020 03:55
@koca
Copy link
Owner

koca commented Feb 11, 2020

Hi jeffrey! Just followed you on twitter. You can write me DM whenever u want.
So Thanks for the try. But it should scroll when the cursor is bottom of the editor. Like when i'm typing in the middle of the editor and i type enter it shouldnt scroll to bottom.
Here is what i mean:

Kapture 2020-02-11 at 21 43 51

@jefrydco
Copy link
Contributor Author

I see, oke let me try that more. It should be worked like this, isn't it?

Screen-Recording-2020-02-12-at-06 31 26

@koca
Copy link
Owner

koca commented Feb 11, 2020

Yep ^^

@koca
Copy link
Owner

koca commented Aug 8, 2020 •
edited

We use textarea in v1 and it shouldnt be a problem anymore.
Thanks :)

@koca koca closed this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koca koca Awaiting requested review from koca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New line scroll bottom
2 participants
@jefrydco @koca