Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch vuex deprecation warning #3849

Merged
merged 2 commits into from Aug 27, 2022
Merged

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kodabot
Copy link
Collaborator

kodabot commented Aug 27, 2022

SUCCESS @preschian PR for issue #2243 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 27, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f422da0
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6309db21e1636f0008567ca6
😎 Deploy Preview https://deploy-preview-3849--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review August 27, 2022 06:24
@preschian preschian requested review from a team as code owners August 27, 2022 06:24
@preschian preschian requested review from prachi00, JustLuuuu and petersopko and removed request for a team and JustLuuuu August 27, 2022 06:24
@codeclimate
Copy link

codeclimate bot commented Aug 27, 2022

Code Climate has analyzed commit f422da0 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian requested a review from yangwao August 27, 2022 09:23
@yangwao
Copy link
Member

yangwao commented Aug 27, 2022

Clean builds 🤩

pay 50

image

@yangwao
Copy link
Member

yangwao commented Aug 27, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 45.26 USD/KSM ~ 1.105 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xfcc0d6d72bc271b0f789a6070e99b8b2159a099097f334b755d9dc3cae61635b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 27, 2022
@yangwao yangwao merged commit bb6dd60 into kodadot:main Aug 27, 2022
@preschian preschian deleted the patch-vuex branch August 27, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEP0148 - update this package.json to use a subpath pattern like "./*"
3 participants