Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch hmr on nuxt bridge #4836

Merged
merged 1 commit into from Jan 26, 2023
Merged

fix: patch hmr on nuxt bridge #4836

merged 1 commit into from Jan 26, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Jan 26, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Jan 26, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 524e7c1
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63d287dfbe25d40008d38df0
😎 Deploy Preview https://deploy-preview-4836--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Jan 26, 2023

Code Climate has analyzed commit 524e7c1 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian marked this pull request as ready for review January 26, 2023 14:14
@preschian preschian requested a review from a team as a code owner January 26, 2023 14:14
@preschian preschian requested review from roiLeo and Jarsen136 and removed request for a team January 26, 2023 14:14
@preschian
Copy link
Member Author

after several attempts, this is the only one that works on my local. could you verify this branch also in your local cc @petersopko @prachi00

Jarsen136
Jarsen136 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

@Jarsen136 Jarsen136 added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jan 26, 2023
@petersopko
Copy link
Contributor

wfm 🚀

@yangwao
Copy link
Member

yangwao commented Jan 26, 2023

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Jan 26, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 34.23 USD/KSM ~ 1.461 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x0d665db8f7a3401e1254f7441c60faa7f818c5999d10429385abe0610c338bea

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 26, 2023
@yangwao yangwao merged commit 40a208e into main Jan 26, 2023
@yangwao yangwao deleted the fix/patch-nuxt-bridge-for-hmr branch January 26, 2023 19:55
@yangwao yangwao removed the paid pull-request has been paid label Jan 27, 2023
@yangwao
Copy link
Member

yangwao commented Jan 27, 2023

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Jan 27, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 35.02 USD/KSM ~ 1.428 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x8cd1f832545683633f7121cf8029a2524eea7400a584dc3e1f4ab60bd8b6f0bf

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@roiLeo roiLeo Awaiting requested review from roiLeo roiLeo is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hot reload gone
4 participants
@preschian @petersopko @yangwao @Jarsen136