Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 ExploreGrid NeoField mb-0 #6180

Merged
merged 2 commits into from
Jun 8, 2023
Merged

🔧 ExploreGrid NeoField mb-0 #6180

merged 2 commits into from
Jun 8, 2023
+426 −961

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 7, 2023 •
edited

Just fyi <NeoField /> component has margin-bottom by default

Screenshot 2023-06-07 at 09-20-15 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner June 7, 2023 07:21
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team June 7, 2023 07:21
@netlify
Copy link

netlify bot commented Jun 7, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0846a6b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6480688f0715ff00075ce096
😎 Deploy Preview https://deploy-preview-6180--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 7, 2023

AI-Generated Summary: This pull request includes changes to the static/sitemap.xml file and the ExploreGrid.vue file. An entry for the waifu endpoint under stmn was added to the sitemap, and the structure of the ExploreGrid.vue file was simplified by removing a <div> wrapper and updating the CSS classes. This results in improved code organization and visual layout of the elements.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jun 7, 2023
Jarsen136
Jarsen136 reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove the unrelated change on these two file. Otherwise lgtm
image

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 7, 2023 •
edited

Pls remove the unrelated change on these two file. Otherwise lgtm

This is more or less related, without this project won't build check issue & description

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jun 7, 2023
@roiLeo roiLeo enabled auto-merge June 7, 2023 08:28
@preschian
Copy link
Member

@roiLeo try to install it with pnpm@8.6.0? https://github.com/kodadot/nft-gallery/blob/main/package.json#L62

@codeclimate
Copy link

codeclimate bot commented Jun 7, 2023

Code Climate has analyzed commit 0846a6b and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 7, 2023

@roiLeo try to install it with pnpm@8.6.0? https://github.com/kodadot/nft-gallery/blob/main/package.json#L62

build with pnpm 8.6.1, with 8.5 I can't run it..

still have uncommit changes

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 7, 2023
@roiLeo roiLeo merged commit 56da407 into kodadot:main Jun 8, 2023
19 checks passed
@roiLeo roiLeo deleted the fix/ExploreGrid/NeoField branch June 8, 2023 06:38
@preschian
Copy link
Member

build with pnpm 8.6.1, with 8.5 I can't run it..

they revert it again on pnpm 8.6.2 😅😅😅 cc @roiLeo
pnpm/pnpm#6648

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 13, 2023

🙄
which is why I don't update my package manager often

This was referenced Jun 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
large Pull request is large S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pnpm build errors Explore buttons alignement
4 participants
@roiLeo @preschian @Jarsen136 @prury