Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs-routes: Lock glob version to 8.x.x for compatibility on Windows #862

Closed

Conversation

rokoucha
Copy link

@rokoucha rokoucha commented Apr 8, 2023

Since the combination of fs-routes and glob 9 or later stopped working on windows, I changed it to explicitly support up to glob 8.

https://github.com/isaacs/node-glob/blob/main/changelog.md#90

@rokoucha rokoucha changed the title fs-routes: Lock glob version to 7.x.x for compatibility on Windows fs-routes: Lock glob version to 8.x.x for compatibility on Windows Apr 8, 2023
@Last-Order
Copy link

According to the docs, the backslash path delimiter is not supported by glob since 8.x. And we can confirm that 8.x is not working in projects using openapi-framework anymore so maybe we should lock the version to 7.x?

@rokoucha
Copy link
Author

rokoucha commented Apr 10, 2023

As far as I have tried, it works fine with glob 8.x.

Paths are returned in the canonical formatting for the platform in question.
https://github.com/isaacs/node-glob/blob/main/changelog.md#90

I think this change may have destroyed it.

@jsdevel
Copy link
Contributor

jsdevel commented Apr 14, 2023

@rokoucha plz fix the build

@rokoucha
Copy link
Author

@jsdevel I fixed it. It seems that it was originally unstable, not broken by my change.

@meyerds
Copy link

meyerds commented Apr 27, 2023

A better option to fix this issue might be to change file on this line to path.posix.normalize(file) which will avoid dependency on a specific glob version (though I haven't tested this fix on a Windows machine, someone will need to do that first)

@jsdevel
Copy link
Contributor

jsdevel commented May 20, 2023

@rokoucha i agree with @meyerds . locking down a dependency potentially opens up this project to dep lock in and security vulnerabilities in the long wrong. can you try fixing it with the latest glob?

@rokoucha
Copy link
Author

rokoucha commented May 21, 2023

OK, I will close this PR and try to fix it with a new PR. thanks for the comments!

@rokoucha rokoucha closed this May 21, 2023
@rokoucha rokoucha deleted the fs-routes-lock-glob-to-9 branch May 21, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants