fix Bug: novelai队列429错误 #217 #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaikoTan
requested changes
Feb 10, 2024
Comment on lines
+289
to
+293
| if (config.globalConcurrency) { | ||
| while (globalTasks.size >= config.globalConcurrency) { | ||
| await sleep(100) | ||
| } | ||
| } |
There was a problem hiding this comment.
Not a great implementation, I think it would be better that you have a pending list caching those pending request and then pick from it when you have requests resolved.
|
@MaikoTan 你可以在这里继续（ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #217