Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-119): add support to run a tenant PipelineRun #451

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

theflockers
Copy link
Collaborator

This commit adds support for running tenant PipelineRuns

Signed-off-by: Leandro Mendes lmendes@redhat.com

Copy link

openshift-ci bot commented May 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 84.69%. Comparing base (70c0c43) to head (8fc1c54).
Report is 5 commits behind head on main.

Files Patch % Lines
controllers/release/adapter.go 66.66% 4 Missing and 2 partials ⚠️
loader/loader.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
- Coverage   84.95%   84.69%   -0.27%     
==========================================
  Files          26       26              
  Lines        1396     1411      +15     
==========================================
+ Hits         1186     1195       +9     
- Misses        152      156       +4     
- Partials       58       60       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theflockers theflockers force-pushed the release_119 branch 2 times, most recently from 7f54b9f to 8fc1c54 Compare May 6, 2024 10:17
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 82.56881% with 19 lines in your changes missing coverage. Please review.

Project coverage is 83.93%. Comparing base (c8b5d9a) to head (c893cf6).
Report is 17 commits behind head on main.

Files Patch % Lines
controllers/release/adapter.go 82.60% 8 Missing and 8 partials ⚠️
controllers/release/controller.go 0.00% 2 Missing ⚠️
loader/loader_mock.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
- Coverage   84.95%   83.93%   -1.02%     
==========================================
  Files          26       26              
  Lines        1396     1488      +92     
==========================================
+ Hits         1186     1249      +63     
- Misses        152      170      +18     
- Partials       58       69      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theflockers
Copy link
Collaborator Author

/ok-to-test

@theflockers theflockers force-pushed the release_119 branch 7 times, most recently from c5750a6 to c3067d4 Compare May 8, 2024 15:55
@theflockers theflockers marked this pull request as ready for review May 8, 2024 15:55
@theflockers theflockers requested a review from a team as a code owner May 8, 2024 15:55
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidmogar is this how we want it? I was under the understanding that the tenant pipeline would execute before, not in place of, the managed pipeline

metadata/labels.go Outdated Show resolved Hide resolved
loader/loader.go Outdated Show resolved Hide resolved
@theflockers
Copy link
Collaborator Author

/test release-service-e2e

@theflockers theflockers force-pushed the release_119 branch 4 times, most recently from a1f89f6 to d671826 Compare May 10, 2024 08:35
@theflockers theflockers marked this pull request as draft May 10, 2024 15:38
@theflockers
Copy link
Collaborator Author

Moving it back to draft as changes are required.

@theflockers
Copy link
Collaborator Author

/retest

johnbieren
johnbieren previously approved these changes May 30, 2024
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with the changes. Now just to get David's approval 🙂

@theflockers
Copy link
Collaborator Author

/retest

@theflockers
Copy link
Collaborator Author

/test all

controllers/release/adapter.go Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2024
This commit adds support for running tenant Pipelines.

Signed-off-by: Leandro Mendes <lmendes@redhat.com>
Copy link

openshift-ci bot commented Jun 4, 2024

New changes are detected. LGTM label has been removed.

@theflockers theflockers merged commit 3860315 into konflux-ci:main Jun 4, 2024
11 checks passed
@theflockers theflockers deleted the release_119 branch June 4, 2024 13:02
theflockers added a commit to theflockers/infra-deployments that referenced this pull request Jun 5, 2024
This commit includes:

- konflux-ci/release-service#473
- konflux-ci/release-service#472
- konflux-ci/release-service#451

Signed-off-by: Leandro Mendes <lmendes@redhat.com>
rhtap-qe-bots-2 pushed a commit to redhat-appstudio-qe/infra-deployments that referenced this pull request Jun 6, 2024
This commit includes:

- konflux-ci/release-service#473
- konflux-ci/release-service#472
- konflux-ci/release-service#451

Signed-off-by: Leandro Mendes <lmendes@redhat.com>
rhtap-qe-bots-2 pushed a commit to redhat-appstudio-qe/infra-deployments that referenced this pull request Jun 6, 2024
This commit includes:

- konflux-ci/release-service#473
- konflux-ci/release-service#472
- konflux-ci/release-service#451

Signed-off-by: Leandro Mendes <lmendes@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants