Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-runtime to get fix for global log override bug #169

Merged
merged 1 commit into from Jun 30, 2022

Conversation

skabashnyuk
Copy link
Collaborator

What does this PR do?

Update controller-runtime to get fix for global log override bug.

Screenshot/screencast of this PR

Знімок екрана 2022-06-30 о 11 28 00

What issues does this PR fix or reference?

All logs reported as "spiaccesscheck" controller logs. See more https://issues.redhat.com/browse/SVPI-160
Issue kubernetes-sigs/controller-runtime#1908
Fixed kubernetes-sigs/controller-runtime#1907

How to test this PR?

  • Deploy quay.io/skabashn/service-provider-integration-operator:main_2022_06_30__10_51_56
  • Create SPIAccessTokenBinding
  • Ensure that logs comes from "controller":"spiaccesstokenbinding"
  • Create SpiAccessCheck
  • Ensure that logs comes from "controller":"spiaccesscheck"

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #169 (28c9c45) into main (3b5cc2b) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   61.52%   61.58%   +0.06%     
==========================================
  Files          51       51              
  Lines        3319     3319              
==========================================
+ Hits         2042     2044       +2     
- Misses       1083     1085       +2     
+ Partials      194      190       -4     
Impacted Files Coverage Δ
controllers/spiaccesscheck_controller.go 31.81% <0.00%> (-22.73%) ⬇️
controllers/spiaccesstokenbinding_controller.go 74.43% <0.00%> (+0.97%) ⬆️
pkg/spi-shared/tokenstorage/vault.go 54.20% <0.00%> (+2.80%) ⬆️
controllers/spiaccesstoken_controller.go 71.42% <0.00%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5cc2b...28c9c45. Read the comment docs.

@skabashnyuk skabashnyuk merged commit bb145f7 into konflux-ci:main Jun 30, 2022
@skabashnyuk skabashnyuk deleted the upruntime branch June 30, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants