Extracted not added items from PR #313 #864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,17 @@ public interface DOMTokenList extends JSObject { | |||
|
|
|||
| void add(String token); | |||
|
|
|||
| void add(String token1, String token2); | |||
|
|
|||
| void add(String... tokens); | |||
There was a problem hiding this comment.
Are you sure that varargs supported in JSO?
There was a problem hiding this comment.
There also was a comment to create issue to support varargs in JS. Ok, will create issue to support varagrs.
There was a problem hiding this comment.
So are they supported or not? If they aren't, I can't accept PR with these declarations
There was a problem hiding this comment.
I thought that you know as author of TeaVM. But ok, will check.
There was a problem hiding this comment.
I'm not a machine remebering each and every character from this repository
There was a problem hiding this comment.
Sorry, didn't want to offend you. Just checked. Varargs are not supported. So, extracted varargs to separate PR #867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/konsoletyper/teavm/pull/313/files
lots of items already were implemented, so I extracted everything that was not implemented. Did not merge it, but I suppose that is should be authored by @niloc132