Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render container as konva container instead of template #185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

boboldehampsink
Copy link

@boboldehampsink boboldehampsink mentioned this pull request Feb 15, 2022
@lavrton
Copy link
Member

lavrton commented Mar 15, 2022

I am still not sure what exactly this Pull Request is fixing. And I am not sure it is a good idea to use container in render.

@boboldehampsink
Copy link
Author

@lavrton it fixes triggering of this line: https://github.com/konvajs/vue-konva/blob/master/src/utils/index.js#L38

It is triggered by these lines: https://github.com/konvajs/vue-konva/blob/master/src/components/KonvaNode.js#L110-L113

which try to render a <template> tag inside the stage, which is not a Konva node and thus forbidden. This PR attempts to use a proper Konva node here: https://konvajs.org/api/Konva.Container.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 3 support
3 participants