Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rolling back to golangci-lint 1.47.3 #449

Merged
merged 1 commit into from Aug 8, 2022

Conversation

jasonliu747
Copy link
Member

@jasonliu747 jasonliu747 commented Aug 8, 2022

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fix #450

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@jasonliu747
Copy link
Member Author

some background info: golangci/golangci-lint-action#535

@eahydra
Copy link
Member

eahydra commented Aug 8, 2022

/lgtm

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #449 (4b885f0) into main (9626a21) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   67.91%   67.94%   +0.02%     
==========================================
  Files         137      137              
  Lines       14980    14980              
==========================================
+ Hits        10174    10178       +4     
+ Misses       4045     4042       -3     
+ Partials      761      760       -1     
Flag Coverage Δ
unittests 67.94% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+4.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hormes
Copy link
Member

hormes commented Aug 8, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4f8f5fc into koordinator-sh:main Aug 8, 2022
@jasonliu747 jasonliu747 deleted the golangci branch August 9, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] golangci 1.48: "Error: File is not gofmt-ed with -s (gofmt)"
3 participants