Migrated Snowflake to inline class #886
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukellmann
reviewed
Oct 24, 2023
| public constructor(value: ULong) { | ||
| this.value = value.coerceIn(validValues) | ||
| init { | ||
| value.coerceIn(validValues) |
There was a problem hiding this comment.
this won't do what you'd expect, the coerced value isn't used
there are a few options i can think of
- change coercion to exception
- hide the constructor and do coercion in a pseudo constructor (if that's even possible, i'm not sure)
- give up on limiting snowflakes and allow creating some that might be rejected by discord's api (see Note on valid Snowflake range discord/discord-api-docs#3745)
Comment on lines
195
to
185
| public val validValues: ULongRange = ULong.MIN_VALUE..Long.MAX_VALUE.toULong() // 0..9223372036854775807 | ||
| public val validValues: ULongRange = ULong.MIN_VALUE..ULong.MAX_VALUE // 0..9223372036854775807 |
Comment on lines
-23
to
-26
| /** | ||
| * The raw value of this Snowflake as specified by the | ||
| * [Discord Developer Documentation](https://discord.com/developers/docs/reference#snowflakes). | ||
| */ |
There was a problem hiding this comment.
i think this documentation should be kept
Comment on lines
99
to
97
| Value(decoder.decodeInline(descriptor).decodeLong().toULong()) | ||
| Value(Snowflake(decoder.decodeInline(descriptor).decodeLong().toULong())) |
There was a problem hiding this comment.
can be delegated to Snowflake's serializer instead
|
Is there an issue already for the problems with mockk? |
|
I've got wrong. This problem isn't related to inline classes, but to unsigned numbers. mockk/mockk#544 |
the issue you pointed to is now closed, is there any update on this? |
|
Yes, issue is closed, but it's not released yet |
zTrap
force-pushed
the
feature/snowflake-inline-class
branch
from
be60171
to
eeac1bd
Compare
zTrap
force-pushed
the
feature/snowflake-inline-class
branch
from
eeac1bd
to
40e43ad
Compare
|
@lukellmann seems like all works fine with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mockk does not yet supported good boxing\unboxing for inline classes. So most equality check related tests are broken