Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Valid.php #516

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Update Valid.php #516

merged 1 commit into from
Jun 3, 2024

Conversation

saruman
Copy link
Contributor

@saruman saruman commented Feb 1, 2024

In PHP 8.1, the FILTER_SANITIZE_STRING filter constant has been deprecated, and FILTER_SANITIZE_EMAIL should be used instead.

PR Details

Provide a general summary of your changes in the Title above

Description

Describe your changes in detail

Related Issue

This project only accepts pull requests related to open issues

If suggesting a new feature or change, please discuss it in an issue first

If fixing a bug, there should be an issue describing it with steps to reproduce

Please link to the issue here

How Has This Been Tested

Please describe in detail how you tested your changes and
see how your change affects other areas of the code, etc.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

In PHP 8.1, the FILTER_SANITIZE_STRING filter constant has been deprecated, and FILTER_SANITIZE_EMAIL should be used instead.
@phpclub
Copy link
Contributor

phpclub commented May 23, 2024

PR is work!
PHP 7.3.7

php vendor/bin/phpunit --filter=ValidTest
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

............................................................... 63 / 246 ( 25%)
............................................................... 126 / 246 ( 51%)
............................................................... 189 / 246 ( 76%)
......................................................... 246 / 246 (100%)

Time: 1.89 seconds, Memory: 34.00 MB

OK (246 tests, 263 assertions)

@toitzi
Copy link
Member

toitzi commented Jun 3, 2024

Merged, thanks!

@toitzi toitzi merged commit ecd9178 into koseven:master Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants