fix: shouldContainJsonKey should be true for keys with null values (#…

…3128) Co-authored-by: Michael Sewell <michael@sewell.blog>
kotest · Jul 29, 2022 · b4dc446 · b4dc446
1 parent e1b4b48
commit b4dc446
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/...st-assertions/kotest-assertions-json/src/jvmMain/kotlin/io/kotest/assertions/json/keys.kt b/...st-assertions/kotest-assertions-json/src/jvmMain/kotlin/io/kotest/assertions/json/keys.kt
@@ -25,8 +25,9 @@ fun containJsonKey(path: String) = object : Matcher<String?> {
          else -> if (value.length < 50) value.trim() else value.substring(0, 50).trim() + "..."
       }
 
-      val passed = try {
-         value != null && JsonPath.read<String>(value, path) != null
+      val passed = value != null && try {
+         JsonPath.read<String>(value, path)
+         true
       } catch (t: PathNotFoundException) {
          false
       }

diff --git a/...ssertions-json/src/jvmTest/kotlin/com/sksamuel/kotest/tests/json/JvmJsonAssertionsTest.kt b/...ssertions-json/src/jvmTest/kotlin/com/sksamuel/kotest/tests/json/JvmJsonAssertionsTest.kt
@@ -116,4 +116,10 @@ class JvmJsonAssertionsTest : StringSpec({
          use(nullableJson)
       }
    }
+
+   "test key with null value" {
+      val testJson1 = """ { "nullable" : null } """
+      testJson1.shouldContainJsonKey("$.nullable")
+      testJson1.shouldContainJsonKeyValue("$.nullable", null as Any?)
+   }
 })