Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldBe/shouldNotBe chain #3186

Merged
merged 10 commits into from
Apr 1, 2023
Merged

shouldBe/shouldNotBe chain #3186

merged 10 commits into from
Apr 1, 2023

Conversation

sksamuel
Copy link
Member

Closes #3170

@sksamuel sksamuel mentioned this pull request Aug 28, 2022
Closed
LeoColman
LeoColman requested changes Aug 31, 2022
View reviewed changes
Copy link
Member

@LeoColman LeoColman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some tests on the return

@LeoColman LeoColman enabled auto-merge (squash) September 28, 2022 18:04
@Kantis Kantis added this to the 5.6 milestone Oct 28, 2022
@Kantis Kantis mentioned this pull request Nov 17, 2022
Merged
@stale
Copy link

stale bot commented Dec 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Dec 23, 2022
@stale stale bot closed this Dec 31, 2022
auto-merge was automatically disabled December 31, 2022 22:16

Pull request was closed

@Kantis Kantis reopened this Jan 16, 2023
@stale stale bot removed the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Jan 16, 2023
@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Mar 18, 2023
@stale stale bot removed the stale 🏚️ Issues that were lost to time and are no longer up-to-date label Mar 21, 2023
@Kantis Kantis enabled auto-merge (squash) March 23, 2023 22:29
@Kantis Kantis disabled auto-merge March 23, 2023 22:30
@Kantis Kantis enabled auto-merge (squash) March 23, 2023 22:30
@Kantis Kantis merged commit 400ebc1 into master Apr 1, 2023
17 checks passed
@Kantis Kantis deleted the feature/3170 branch April 1, 2023 22:37
@philBrown
Copy link

This represents a breaking change to the API and should never have been released as a minor update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoColman LeoColman LeoColman approved these changes

@myuwono myuwono myuwono approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.

shouldBe() / shouldNotBe() don't chain
5 participants
@sksamuel @philBrown @LeoColman @myuwono @Kantis