Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Collections Matchers from top-level Matchers pages in docs #3458

Merged
merged 4 commits into from
Apr 2, 2023

Conversation

avarun42
Copy link
Contributor

Updated latest version of documentation as well as documentation for upcoming version

@Kantis
Copy link
Member

Kantis commented Mar 21, 2023

Collection matchers are part of the core matchers. All other listed modules are in different dependencies, so I think we should reconsider this change. Perhaps it's better to make collections a clearer part of the core matchers?

@avarun42
Copy link
Contributor Author

Either way there should be some way to get to them from the Matchers page in the docs. Currently there is no way, which is extremely confusing.

It would be reasonable to consolidate the Collections matchers page into the Core matchers page, but that can be part of a larger documentation cleanup effort. As it is, it doesn't make sense to leave the Collections page as difficult as it is to find.

@sksamuel
Copy link
Member

sksamuel commented Apr 2, 2023

It's not consistent atm for sure, but there's no harm in adding the link given collection matchers are already a separate page?

@sksamuel sksamuel merged commit bc24279 into kotest:master Apr 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants