Expose discovered specs as TestDescriptors during discovery and add support for unique IDs #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than storing the discovered spec classes in KotestEngineDescriptor it now uses exposes them as child TestDescriptors so that tools and IDEs can inspect the test plan prior to executing it. Co-authored-by: Jérôme Prinet <jprinet@gradle.com>
Based on a previously discovered `TestPlan`, tools may decide to split it and use `UniqueIdSelectors` to create multiple smaller `TestPlans`. Another use case is rerunning a test class, for example, because it failed. Co-authored-by: Jérôme Prinet <jprinet@gradle.com>
marcphilipp
force-pushed
the
marc/unique-id-discovery
branch
from
054f157
to
f5bc90b
Compare
|
Looks good to me, but it's a bit beyond me. Would like to have @sksamuel eyes on this |
|
@sksamuel Please let me know if you have any questions. I'd be happy to schedule a call with you if that makes it easier for you to review these changes. |
marcphilipp
changed the title
|
I'll review this weekend just been slammed at work.
…On Wed, Mar 29, 2023, 3:36 AM Marc Philipp ***@***.***> wrote:
@sksamuel <https://github.com/sksamuel> Please let me know if you have
any questions. I'd be happy to schedule a call with you if that makes it
easier for you to review these changes.
—
Reply to this email directly, view it on GitHub
<#3461 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGXO25HEI7R6HXAQLYTW6PX7VANCNFSM6AAAAAAWBGJJNE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
sksamuel
approved these changes
Apr 2, 2023
|
@sksamuel Thanks for the review and merging it! Should this PR be assigned to a milestone? Will it be released with 5.6? If so, do you have a rough estimate when that will be shipped? |
|
Yes it'll go out with 5.6 later this week.
…On Tue, Apr 4, 2023, 2:07 AM Marc Philipp ***@***.***> wrote:
@sksamuel <https://github.com/sksamuel> Thanks for the review and merging
it! Should this PR be assigned to a milestone? Will it be released with
5.6? If so, do you have a rough estimate when that will be shipped?
—
Reply to this email directly, view it on GitHub
<#3461 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGVBBDMLS3CBILMLCFLW7PCELANCNFSM6AAAAAAWBGJJNE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Kotest compatible with the requirements that are documented in the JUnit User Guide for interoperability with build tools and IDEs.
In particular the following two properties were not met prior to this change:
For Gradle Enterprise, we are relying on these properties in order to select a subset of the
TestPlanfor Predictive Test Selection and in order to split it into subsets that can be distributed with Test Distribution. Therefore, our customers could not use neither of these features when using Kotest. However, we’re convinced other tools will also benefit from Kotest being more inline with otherTestEngineimplementations such as JUnit Jupiter or Spock to provide a consistent user experience for their users.