Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move constant now to new module; bump junit to 1.8.2 #3470

Merged
merged 9 commits into from
Apr 3, 2023
Merged

Conversation

sksamuel
Copy link
Member

@sksamuel sksamuel commented Apr 2, 2023

Fixes #3433 #3391

Bumps junit to 1.8.2
Moves the constant now extensions to a new module that avoids bringing mockk into the regular extensions.

@sksamuel sksamuel requested a review from Kantis April 2, 2023 07:17
@sksamuel sksamuel enabled auto-merge (squash) April 2, 2023 17:44
@sksamuel sksamuel disabled auto-merge April 2, 2023 21:50
@sksamuel sksamuel enabled auto-merge (squash) April 2, 2023 21:50
@sksamuel sksamuel disabled auto-merge April 3, 2023 03:12
@sksamuel sksamuel merged commit 596239a into master Apr 3, 2023
17 checks passed
@sksamuel sksamuel deleted the fix/3433 branch April 3, 2023 03:12
@obecker
Copy link
Contributor

obecker commented Apr 18, 2023

Apparently MutableClock has been silently removed. I don't see any connection to the linked issues. Could you please share what the proper replacement is? Thank you.

@sksamuel
Copy link
Member Author

sksamuel commented Apr 19, 2023 via email

@obecker
Copy link
Contributor

obecker commented Apr 19, 2023

Ah, ok. It's the TestClock in https://github.com/kotest/kotest-extensions-clock
Thanks

@sksamuel
Copy link
Member Author

The mutable clock was only added as an internal implementation, and it was a mistake for us to make it public. The test clock repo is a better way to provide this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JUnit Platform Version Clash
3 participants