Add wasmJs target #3805

OliverO2 · 2023-12-13T16:41:48Z

Includes:

Migrating to Kotlin 1.9.23 (with support for 2.0.0-Beta2), Gradle 8.6
Using kotlinx.coroutines 1.8.0
Simplifying the source set hierarchy in build scripts
Adding a common jsHosted source set for JS-hosted targets (js and wasmJs)
Removing watchosX86 and iosArm32 targets
Deprecating kotest-extensions-http, meanwhile restricting it to JVM

Some seemingly common functions like js() and CoroutineScope.promise() have different signatures and requirements.

OliverO2 · 2023-12-15T22:33:01Z

Current status: Waiting for resolution or workaround regarding KT-64357 K/Wasm: "CompileError: WebAssembly.Module(): Invalid types for ref.test: local.get of type externref has to be in the same reference type hierarchy as (ref ...)"

OliverO2 · 2023-12-16T21:44:42Z

Status update: There is a problem with wasmJs test invocations. While Mocha functions like describe and it are available with js tests, they are not with wasmJs. This prevents execution of Node-based and browser-based tests for wasmJs. The problem can be reproduced independently of Kotest (kotlinlang Slack). Once that problem is resolved, I'm expecting this PR to become ready for review.

jsNodeTest must remain disabled until #3329 gets fixed

eygraber · 2024-01-17T17:37:14Z

@OliverO2 is there anything to track in terms of this getting unblocked?

OliverO2 · 2024-01-17T18:14:18Z

@eygraber No, AFAIK there is nothing blocking this technically, it's just a matter of review resources, since this is not exactly a tiny PR. Also, we'd possibly have to unbundle the Ktor extension in a separate step, as Ktor/Wasm currently requires the upcoming Ktor 3.0 version.

ajalt · 2024-02-21T18:45:42Z

buildSrc/src/main/kotlin/kotest-native-conventions.gradle.kts

-         val tvosX64Test by getting { dependsOn(nativeTest) }
-         val tvosArm64Test by getting { dependsOn(nativeTest) }
-         val tvosSimulatorArm64Test by getting { dependsOn(nativeTest) }
+      // FIXME: WORKAROUND https://github.com/Kotlin/kotlinx.coroutines/issues/3968


@OliverO2 FYI coroutines 1.8.0 is out now with a fix for this bug, so the workaround is no longer necessary

Yep. Thanks for the reminder. I'll get back to this as soon as someone is ready for a complete review (but no sooner than March, 4th due to other commitments). Looking forward to updating this and possibly other dependencies then.

Kantis

Nice work @OliverO2 🙌🏼

Some small things to clean up, but I think it would be great to get this out when you have time again.

Kantis · 2024-02-03T20:42:47Z

buildSrc/src/main/kotlin/Ci.kt

@@ -2,7 +2,7 @@ object Ci {

   // this is the version used for building snapshots
   // .buildnumber-snapshot will be appended
-   private const val snapshotBase = "5.9.0"
+   private const val snapshotBase = "5.8.999"


Should this be reverted before merging?

buildSrc/src/main/kotlin/kotest-android-native-conventions.gradle.kts

kotest-framework/kotest-framework-engine/src/commonMain/kotlin/io/kotest/engine/TestEngine.kt

Kantis · 2024-03-07T07:19:31Z

...amework/kotest-framework-engine/src/commonMain/kotlin/io/kotest/engine/TestEngineLauncher.kt

@@ -192,6 +191,7 @@ class TestEngineLauncher(
   }

   fun withJs(): TestEngineLauncher = withPlatform(Platform.JS)
+   fun withWasmJs(): TestEngineLauncher = withPlatform(Platform.WasmJs).withTeamCityListener()


Why do we add the TeamCityListener here, and only for wasm?

It is remarkably complicated: The TeamCityListener formats test output in the "TeamCity" format. While on the JS platform, the same is accomplished by the Kotlin test infra (via Mocha), this is not the case for wasmJs (which does not use Mocha). Without the extra TeamCityListener, gradlew test in kotest:kotest-framework:kotest-framework-multiplatform-plugin-gradle fails. For details, see this Slack thread.

Kantis · 2024-03-07T07:20:32Z

kotest-framework/kotest-framework-engine/src/commonMain/kotlin/io/kotest/engine/spec/sorters.kt

@@ -22,7 +22,7 @@ interface SpecSorter {
 /**
 * An implementation of [SpecExecutionOrder] which will order specs in lexicographic order.
 */
-object LexicographicSpecSorter : SpecSorter {
+val LexicographicSpecSorter = object : SpecSorter {


Breaking change i reckon. Do we want to make it internal while we're at it?

Sure, makes sense.

Kantis · 2024-03-07T07:24:41Z

kotest-framework/kotest-framework-engine/src/wasmJsMain/kotlin/KotlinTestApi.kt

+   // The Kotlin compiler would insert test invocations here for kotlin-test.
+   // This mechanism is not used with Kotest.


Do we have any documentation on how this works in Kotest instead? I keep forgetting. :(

I wouldn't call it documentation, but it can be inferred from sources in kotest-framework-multiplatform-plugin-embeddable-compiler/src/jvmMain/kotlin/io/kotest/framework/multiplatform/embeddablecompiler, in particular entry.kt.

Kantis · 2024-03-07T07:28:00Z

kotest-framework/kotest-framework-multiplatform-plugin-gradle/test-project/build.gradle.kts

+
+rootProject.plugins.withType<org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootPlugin> {
+   rootProject.extensions.configure<org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootExtension> {
+      nodeVersion = "22.0.0-v8-canary20231213fc7703246e"


Should this be updated/changed before merge?

The regular 22.x Node.js release is scheduled for April. Until then, we must carefully select a pre-release which works with the Kotlin compiler infra (newest 22.0.0 canaries no longer support the '--experimental-wasm-gc' option). Meanwhile, I'll update to a compatible Node.js release mentioned in KT-65864.

OliverO2 · 2024-03-07T22:40:11Z

@Kantis, @sksamuel
Before merging this, can we decide what to do with kotest-extensions-http? It builds with kotest-js-conventions, which would include Wasm/JS. It also uses Ktor dependencies, which have Wasm support only for a Beta release. kotest-extensions-http does not appear in documentation and is probably not used that much.

So should we

Drop kotest-extensions-http entirely?
Make it build for Jvm only?
Craft a special build for JS, but not Wasm/JS?
Move kotest-extensions-http to a separate repo?
Do something else?

Kantis · 2024-03-08T06:00:01Z

I believe 4 is appropriate

…d-wasm-target

OliverO2 · 2024-03-08T09:45:07Z

Moving kotest-extensions-http to a separate repo should happen in a separate PR. For now, I have reverted the changes that would require Ktor 3.0.0-wasm2 and restricted the extension to build for JVM only. I have found that its main functionality is JVM-only anyway (requiring resource file access) and it has not been updated to work with current Ktor 2 versions.

So this seems to be the best intermediate step for now, enabling this PR to get merged.

Kantis · 2024-03-08T16:35:12Z

I've begun setting up the extension here

But let's proceed like you suggested..

Is everything ready for final review now?

OliverO2 · 2024-03-08T16:55:10Z

Yes. This one is complete and ready. How best to merge it given Sam's intention of getting out 5.8.1 this week (see kotlinlang Slack)?

# Conflicts: # kotest-assertions/kotest-assertions-core/api/kotest-assertions-core.api

OliverO2 · 2024-03-11T13:01:23Z

If there are no objections, I'd merge this within 24 hours so that other PRs can align.

sksamuel · 2024-03-11T13:03:49Z

👍🏻

sksamuel · 2024-03-11T13:05:11Z

...ions/kotest-assertions-shared/src/jsHostedMain/kotlin/io/kotest/assertions/print/printers.kt

+
+// js doesn't support full reflection so we just need to delegate to the instances toString
+actual fun <A : Any> dataClassPrint(): Print<A> = ToStringPrint
+actual fun <A : Any> platformPrint(a: A): Print<A>? = null


What is jsHosted?

jsHosted is the common source set for Kotlin/JS and Kotlin/Wasm/JS, both of which operate within a JS host environment. In the near future, there will be Kotlin/Wasm/WASI (not JS-hosted).

Defined here: https://github.com/kotest/kotest/pull/3805/files#diff-8eba8e3034dadebe1b9bae3190de6c5de838ea157d15ac6fe48d54291883bf0a

By within a js host, does that mean executes within a JS engine/vm?
And Kotlin/Wasm/WASI will not require a js engine ?

Yes, a JS host means that a JS engine is available, providing access to JS APIs (though the bridging process slows things down). The JS engine also shares its garbage collector with GC-based languages targeting Wasm (like Kotlin).

Yes. Pure WASI runtimes like Wasmtime or WasmEdge have no JS engine at all. These seem to become the fast (microsecond startup times), lightweight, language-independent, universal virtualization runtimes of the future (no more Docker). (There's also Node.js, which does have a V8-based WASI runtime.)

Ticket to track: KT-60278 Make Kotlin/Wasm suitable for standalone Wasm VMs

sksamuel · 2024-03-11T14:06:57Z

kotest-common/src/desktopMain/kotlin/io/kotest/mpp/sysprop.kt

 import platform.posix.getenv
 import kotlinx.cinterop.toKString

 actual fun sysprop(name: String): String? = null
+@OptIn(ExperimentalForeignApi::class)


Whats ExperimentalForeignApi do

Don't remember exactly, seems to be required when calling this one (which was there before):

/** * @return the [kotlin.String] decoded from given zero-terminated UTF-8-encoded C string. */ @ExperimentalForeignApi public fun CPointer<ByteVar>.toKString(): String = this.toKStringFromUtf8()

All of the foreign language APIs (CPointer etc.) are experimental.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.kotest:kotest-runner-junit5](https://togithub.com/kotest/kotest) | `5.8.1` -> `5.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.kotest:kotest-runner-junit5/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.kotest:kotest-runner-junit5/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.kotest:kotest-runner-junit5/5.8.1/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.kotest:kotest-runner-junit5/5.8.1/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kotest/kotest (io.kotest:kotest-runner-junit5)</summary> ### [`v5.9.0`](https://togithub.com/kotest/kotest/releases/tag/v5.9.0) #### Highlights Support for wasmJs has been added, curtesy of [@OliverO2](https://togithub.com/OliverO2) #### What's Changed - Add wasmJs target by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3805 - fix(docs): indentation in System Extensions by [@craigpastro](https://togithub.com/craigpastro) in [kotest/kotest#3940 - Change Arb.filterIsInstance() signature to use single type parameter by [@kshired](https://togithub.com/kshired) in [kotest/kotest#3943 - Add missing functions to property-arbs docs by [@snowe2010](https://togithub.com/snowe2010) in [kotest/kotest#3945 - Increasing JVM heap allowance on GitHub by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#3948 - Fix JS and Wasm/JS test timeouts, bring back Node.js test output by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3953 - add-similarity-to-contains-draft ([#42](https://togithub.com/kotest/kotest/issues/42)) by [@AlexCue987](https://togithub.com/AlexCue987) in [kotest/kotest#3906 - Update Sonatype snapshot URL by [@aSemy](https://togithub.com/aSemy) in [kotest/kotest#3956 - Fix json assertions artifact coordinate in docs by [@TWiStErRob](https://togithub.com/TWiStErRob) in [kotest/kotest#3968 - Create CODE_OF_CONDUCT.md by [@sschuberth](https://togithub.com/sschuberth) in [kotest/kotest#3987 - Restructure Kotlin/JS and Kotlin/JS/Wasm testing, fix [#3329](https://togithub.com/kotest/kotest/issues/3329) by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3954 - Correct Collection Matchers Documentation For `collection.shouldContainAllInAnyOrder()` by [@u-ways-e](https://togithub.com/u-ways-e) in [kotest/kotest#3995 - chore(deps): update plugin com.gradle.enterprise to v3.17.2 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3990 - Add kotlin-faker to extensions list by [@serpro69](https://togithub.com/serpro69) in [kotest/kotest#3971 - Better assertion failures for containJsonKeyValue by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#3949 - fix(deps): update dependency io.github.classgraph:classgraph to v4.8.172 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3957 - Add similarity to contain exactly in any order by [@AlexCue987](https://togithub.com/AlexCue987) in [kotest/kotest#3938 - Fix Arb.list failing within edge cases in case of null values by [@oliverblaha](https://togithub.com/oliverblaha) in [kotest/kotest#3982 - chore(deps): update plugin kotlinbinarycompatibilityvalidator to v0.14.0 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3993 - chore(deps): update plugin io.kotest.multiplatform to v5.8.1 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3992 - fixing the kotest autoscan warning message to reference the right property name by [@stepanv](https://togithub.com/stepanv) in [kotest/kotest#4000 - fix(deps): update dependency io.projectreactor.tools:blockhound to v1.0.9.release by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3989 - Allow comparison between empty set and other iterables by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#4005 - Moving similarity feature to kotest-assertions-core by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#4006 #### New Contributors - [@craigpastro](https://togithub.com/craigpastro) made their first contribution in [kotest/kotest#3940 - [@snowe2010](https://togithub.com/snowe2010) made their first contribution in [kotest/kotest#3945 - [@TWiStErRob](https://togithub.com/TWiStErRob) made their first contribution in [kotest/kotest#3968 - [@u-ways-e](https://togithub.com/u-ways-e) made their first contribution in [kotest/kotest#3995 - [@serpro69](https://togithub.com/serpro69) made their first contribution in [kotest/kotest#3971 - [@stepanv](https://togithub.com/stepanv) made their first contribution in [kotest/kotest#4000 **Full Changelog**: kotest/kotest@v5.8.1...v5.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/StefanLobbenmeier/yt-dlp-compose).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.kotest:kotest-bom](https://togithub.com/kotest/kotest) | `5.8.1` -> `5.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.kotest:kotest-bom/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.kotest:kotest-bom/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.kotest:kotest-bom/5.8.1/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.kotest:kotest-bom/5.8.1/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kotest/kotest (io.kotest:kotest-bom)</summary> ### [`v5.9.0`](https://togithub.com/kotest/kotest/releases/tag/v5.9.0) #### Highlights Support for wasmJs has been added, curtesy of [@OliverO2](https://togithub.com/OliverO2) #### What's Changed - Add wasmJs target by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3805 - fix(docs): indentation in System Extensions by [@craigpastro](https://togithub.com/craigpastro) in [kotest/kotest#3940 - Change Arb.filterIsInstance() signature to use single type parameter by [@kshired](https://togithub.com/kshired) in [kotest/kotest#3943 - Add missing functions to property-arbs docs by [@snowe2010](https://togithub.com/snowe2010) in [kotest/kotest#3945 - Increasing JVM heap allowance on GitHub by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#3948 - Fix JS and Wasm/JS test timeouts, bring back Node.js test output by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3953 - add-similarity-to-contains-draft ([#42](https://togithub.com/kotest/kotest/issues/42)) by [@AlexCue987](https://togithub.com/AlexCue987) in [kotest/kotest#3906 - Update Sonatype snapshot URL by [@aSemy](https://togithub.com/aSemy) in [kotest/kotest#3956 - Fix json assertions artifact coordinate in docs by [@TWiStErRob](https://togithub.com/TWiStErRob) in [kotest/kotest#3968 - Create CODE_OF_CONDUCT.md by [@sschuberth](https://togithub.com/sschuberth) in [kotest/kotest#3987 - Restructure Kotlin/JS and Kotlin/JS/Wasm testing, fix [#3329](https://togithub.com/kotest/kotest/issues/3329) by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3954 - Correct Collection Matchers Documentation For `collection.shouldContainAllInAnyOrder()` by [@u-ways-e](https://togithub.com/u-ways-e) in [kotest/kotest#3995 - chore(deps): update plugin com.gradle.enterprise to v3.17.2 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3990 - Add kotlin-faker to extensions list by [@serpro69](https://togithub.com/serpro69) in [kotest/kotest#3971 - Better assertion failures for containJsonKeyValue by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#3949 - fix(deps): update dependency io.github.classgraph:classgraph to v4.8.172 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3957 - Add similarity to contain exactly in any order by [@AlexCue987](https://togithub.com/AlexCue987) in [kotest/kotest#3938 - Fix Arb.list failing within edge cases in case of null values by [@oliverblaha](https://togithub.com/oliverblaha) in [kotest/kotest#3982 - chore(deps): update plugin kotlinbinarycompatibilityvalidator to v0.14.0 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3993 - chore(deps): update plugin io.kotest.multiplatform to v5.8.1 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3992 - fixing the kotest autoscan warning message to reference the right property name by [@stepanv](https://togithub.com/stepanv) in [kotest/kotest#4000 - fix(deps): update dependency io.projectreactor.tools:blockhound to v1.0.9.release by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3989 - Allow comparison between empty set and other iterables by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#4005 - Moving similarity feature to kotest-assertions-core by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#4006 #### New Contributors - [@craigpastro](https://togithub.com/craigpastro) made their first contribution in [kotest/kotest#3940 - [@snowe2010](https://togithub.com/snowe2010) made their first contribution in [kotest/kotest#3945 - [@TWiStErRob](https://togithub.com/TWiStErRob) made their first contribution in [kotest/kotest#3968 - [@u-ways-e](https://togithub.com/u-ways-e) made their first contribution in [kotest/kotest#3995 - [@serpro69](https://togithub.com/serpro69) made their first contribution in [kotest/kotest#3971 - [@stepanv](https://togithub.com/stepanv) made their first contribution in [kotest/kotest#4000 **Full Changelog**: kotest/kotest@v5.8.1...v5.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/typesafegithub/github-actions-typing).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.kotest:kotest-assertions-core](https://togithub.com/kotest/kotest) | `5.8.1` -> `5.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.kotest:kotest-assertions-core/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.kotest:kotest-assertions-core/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.kotest:kotest-assertions-core/5.8.1/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.kotest:kotest-assertions-core/5.8.1/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kotest/kotest (io.kotest:kotest-assertions-core)</summary> ### [`v5.9.0`](https://togithub.com/kotest/kotest/releases/tag/v5.9.0) #### Highlights Support for wasmJs has been added, curtesy of [@OliverO2](https://togithub.com/OliverO2) #### What's Changed - Add wasmJs target by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3805 - fix(docs): indentation in System Extensions by [@craigpastro](https://togithub.com/craigpastro) in [kotest/kotest#3940 - Change Arb.filterIsInstance() signature to use single type parameter by [@kshired](https://togithub.com/kshired) in [kotest/kotest#3943 - Add missing functions to property-arbs docs by [@snowe2010](https://togithub.com/snowe2010) in [kotest/kotest#3945 - Increasing JVM heap allowance on GitHub by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#3948 - Fix JS and Wasm/JS test timeouts, bring back Node.js test output by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3953 - add-similarity-to-contains-draft ([#42](https://togithub.com/kotest/kotest/issues/42)) by [@AlexCue987](https://togithub.com/AlexCue987) in [kotest/kotest#3906 - Update Sonatype snapshot URL by [@aSemy](https://togithub.com/aSemy) in [kotest/kotest#3956 - Fix json assertions artifact coordinate in docs by [@TWiStErRob](https://togithub.com/TWiStErRob) in [kotest/kotest#3968 - Create CODE_OF_CONDUCT.md by [@sschuberth](https://togithub.com/sschuberth) in [kotest/kotest#3987 - Restructure Kotlin/JS and Kotlin/JS/Wasm testing, fix [#3329](https://togithub.com/kotest/kotest/issues/3329) by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3954 - Correct Collection Matchers Documentation For `collection.shouldContainAllInAnyOrder()` by [@u-ways-e](https://togithub.com/u-ways-e) in [kotest/kotest#3995 - chore(deps): update plugin com.gradle.enterprise to v3.17.2 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3990 - Add kotlin-faker to extensions list by [@serpro69](https://togithub.com/serpro69) in [kotest/kotest#3971 - Better assertion failures for containJsonKeyValue by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#3949 - fix(deps): update dependency io.github.classgraph:classgraph to v4.8.172 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3957 - Add similarity to contain exactly in any order by [@AlexCue987](https://togithub.com/AlexCue987) in [kotest/kotest#3938 - Fix Arb.list failing within edge cases in case of null values by [@oliverblaha](https://togithub.com/oliverblaha) in [kotest/kotest#3982 - chore(deps): update plugin kotlinbinarycompatibilityvalidator to v0.14.0 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3993 - chore(deps): update plugin io.kotest.multiplatform to v5.8.1 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3992 - fixing the kotest autoscan warning message to reference the right property name by [@stepanv](https://togithub.com/stepanv) in [kotest/kotest#4000 - fix(deps): update dependency io.projectreactor.tools:blockhound to v1.0.9.release by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3989 - Allow comparison between empty set and other iterables by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#4005 - Moving similarity feature to kotest-assertions-core by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#4006 #### New Contributors - [@craigpastro](https://togithub.com/craigpastro) made their first contribution in [kotest/kotest#3940 - [@snowe2010](https://togithub.com/snowe2010) made their first contribution in [kotest/kotest#3945 - [@TWiStErRob](https://togithub.com/TWiStErRob) made their first contribution in [kotest/kotest#3968 - [@u-ways-e](https://togithub.com/u-ways-e) made their first contribution in [kotest/kotest#3995 - [@serpro69](https://togithub.com/serpro69) made their first contribution in [kotest/kotest#3971 - [@stepanv](https://togithub.com/stepanv) made their first contribution in [kotest/kotest#4000 **Full Changelog**: kotest/kotest@v5.8.1...v5.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/TeamDev-IP/JxBrowser-Gradle-Plugin).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.kotest:kotest-property](https://togithub.com/kotest/kotest) | `5.8.1` -> `5.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.kotest:kotest-property/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.kotest:kotest-property/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.kotest:kotest-property/5.8.1/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.kotest:kotest-property/5.8.1/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.kotest:kotest-assertions-core](https://togithub.com/kotest/kotest) | `5.8.1` -> `5.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.kotest:kotest-assertions-core/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.kotest:kotest-assertions-core/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.kotest:kotest-assertions-core/5.8.1/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.kotest:kotest-assertions-core/5.8.1/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kotest/kotest (io.kotest:kotest-property)</summary> ### [`v5.9.0`](https://togithub.com/kotest/kotest/releases/tag/v5.9.0) #### Highlights Support for wasmJs has been added, curtesy of [@OliverO2](https://togithub.com/OliverO2) #### What's Changed - Add wasmJs target by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3805 - fix(docs): indentation in System Extensions by [@craigpastro](https://togithub.com/craigpastro) in [kotest/kotest#3940 - Change Arb.filterIsInstance() signature to use single type parameter by [@kshired](https://togithub.com/kshired) in [kotest/kotest#3943 - Add missing functions to property-arbs docs by [@snowe2010](https://togithub.com/snowe2010) in [kotest/kotest#3945 - Increasing JVM heap allowance on GitHub by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#3948 - Fix JS and Wasm/JS test timeouts, bring back Node.js test output by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3953 - add-similarity-to-contains-draft ([#42](https://togithub.com/kotest/kotest/issues/42)) by [@AlexCue987](https://togithub.com/AlexCue987) in [kotest/kotest#3906 - Update Sonatype snapshot URL by [@aSemy](https://togithub.com/aSemy) in [kotest/kotest#3956 - Fix json assertions artifact coordinate in docs by [@TWiStErRob](https://togithub.com/TWiStErRob) in [kotest/kotest#3968 - Create CODE_OF_CONDUCT.md by [@sschuberth](https://togithub.com/sschuberth) in [kotest/kotest#3987 - Restructure Kotlin/JS and Kotlin/JS/Wasm testing, fix [#3329](https://togithub.com/kotest/kotest/issues/3329) by [@OliverO2](https://togithub.com/OliverO2) in [kotest/kotest#3954 - Correct Collection Matchers Documentation For `collection.shouldContainAllInAnyOrder()` by [@u-ways-e](https://togithub.com/u-ways-e) in [kotest/kotest#3995 - chore(deps): update plugin com.gradle.enterprise to v3.17.2 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3990 - Add kotlin-faker to extensions list by [@serpro69](https://togithub.com/serpro69) in [kotest/kotest#3971 - Better assertion failures for containJsonKeyValue by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#3949 - fix(deps): update dependency io.github.classgraph:classgraph to v4.8.172 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3957 - Add similarity to contain exactly in any order by [@AlexCue987](https://togithub.com/AlexCue987) in [kotest/kotest#3938 - Fix Arb.list failing within edge cases in case of null values by [@oliverblaha](https://togithub.com/oliverblaha) in [kotest/kotest#3982 - chore(deps): update plugin kotlinbinarycompatibilityvalidator to v0.14.0 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3993 - chore(deps): update plugin io.kotest.multiplatform to v5.8.1 by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3992 - fixing the kotest autoscan warning message to reference the right property name by [@stepanv](https://togithub.com/stepanv) in [kotest/kotest#4000 - fix(deps): update dependency io.projectreactor.tools:blockhound to v1.0.9.release by [@renovate](https://togithub.com/renovate) in [kotest/kotest#3989 - Allow comparison between empty set and other iterables by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#4005 - Moving similarity feature to kotest-assertions-core by [@Kantis](https://togithub.com/Kantis) in [kotest/kotest#4006 #### New Contributors - [@craigpastro](https://togithub.com/craigpastro) made their first contribution in [kotest/kotest#3940 - [@snowe2010](https://togithub.com/snowe2010) made their first contribution in [kotest/kotest#3945 - [@TWiStErRob](https://togithub.com/TWiStErRob) made their first contribution in [kotest/kotest#3968 - [@u-ways-e](https://togithub.com/u-ways-e) made their first contribution in [kotest/kotest#3995 - [@serpro69](https://togithub.com/serpro69) made their first contribution in [kotest/kotest#3971 - [@stepanv](https://togithub.com/stepanv) made their first contribution in [kotest/kotest#4000 **Full Changelog**: kotest/kotest@v5.8.1...v5.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arrow-kt/arrow-website).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alejandro Serrano <trupill@gmail.com>

OliverO2 added 6 commits December 12, 2023 23:52

Migrate to Kotlin 1.9.21, Gradle 8.4

2fa0750

Add wasmJs target

94e6098

Update apiDump

cf09a7a

Enable Wasm compiler plugin, separate JS and WasmJs invocations

33124af

Some seemingly common functions like js() and CoroutineScope.promise() have different signatures and requirements.

CI/test_linux: Fix typo for wasmJsTest

cfb266c

Support Kotlin 2.0.0-Beta2 compilation

8a2e9fb

OliverO2 added 3 commits December 16, 2023 00:07

Add workaround for KT-64357 K/Wasm: "CompileError...: Invalid types..."

62c7f48

Update apiDump

5011cec

Add workaround for K/Wasm limitation in JS interop exception handling

b2dc09f

OliverO2 added 2 commits December 17, 2023 23:55

Fix wasmJsNode tests

fa10c50

multiplatform-plugin-gradle/test: disable wasmJsBrowserTest

d62df28

OliverO2 changed the title ~~WIP: Add Wasm target(s)~~ Add wasmJs target Dec 17, 2023

OliverO2 requested review from sksamuel and Kantis December 18, 2023 00:00

OliverO2 added 5 commits December 18, 2023 19:41

Fix wasmJsBrowser tests

8b8fb94

Engine/plugin testing: add breaking test, disable jsNodeTest

6d0bb50

jsNodeTest must remain disabled until #3329 gets fixed

jasmineTestAPI: rename 'implementationCallback' to 'done' as in Mocha

f2410d6

clean up

1394cd3

Update apiDump

6e03aef

eygraber mentioned this pull request Jan 7, 2024

Re-enable tests for portal eygraber/portal#596

Merged

charlee-dev mentioned this pull request Jan 25, 2024

Add WasmJs target copper-leaf/gradle-convention-plugins#1

Open

Kantis mentioned this pull request Feb 4, 2024

Wasm support Kantis/ks3#100

Open

ajalt reviewed Feb 21, 2024

View reviewed changes

Kantis added this to the 5.9 milestone Feb 24, 2024

Kantis approved these changes Mar 7, 2024

View reviewed changes

Merge branch 'master' into oo2/add-wasm-target

f04a548

OliverO2 and others added 3 commits March 7, 2024 22:49

Address review findings, update dependencies

8512423

Update apiDump

3104834

Merge branch 'master' into oo2/add-wasm-target

c1364e8

OliverO2 added 2 commits March 8, 2024 10:33

kotest-extensions-http: Revert from Ktor 3.0.0-wasm2 to 1.6.8, JVM only

8489cf7

Merge remote-tracking branch 'origin/oo2/add-wasm-target' into oo2/ad…

362b0af

…d-wasm-target

Merge branch 'master' into oo2/add-wasm-target

9cd9cce

OliverO2 mentioned this pull request Mar 10, 2024

JS nested tests v2 #3913

Open

OliverO2 added 2 commits March 11, 2024 10:35

Merge branch 'master' into oo2/add-wasm-target

5542e11

# Conflicts: # kotest-assertions/kotest-assertions-core/api/kotest-assertions-core.api

Deprecate kotest-extensions-http

9d70c8b

sksamuel reviewed Mar 11, 2024

View reviewed changes

OliverO2 added this pull request to the merge queue Mar 12, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2024

OliverO2 added this pull request to the merge queue Mar 12, 2024

Merged via the queue into master with commit 2a61950 Mar 12, 2024
15 checks passed

OliverO2 deleted the oo2/add-wasm-target branch March 12, 2024 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add wasmJs target #3805

Add wasmJs target #3805

OliverO2 commented Dec 13, 2023 •

edited

OliverO2 commented Dec 15, 2023

OliverO2 commented Dec 16, 2023

eygraber commented Jan 17, 2024

OliverO2 commented Jan 17, 2024

ajalt Feb 21, 2024

OliverO2 Feb 21, 2024

Kantis left a comment

Kantis Feb 3, 2024

OliverO2 Mar 7, 2024

Kantis Mar 7, 2024

OliverO2 Mar 7, 2024

Kantis Mar 7, 2024

OliverO2 Mar 7, 2024

Kantis Mar 7, 2024

OliverO2 Mar 7, 2024

Kantis Mar 7, 2024

OliverO2 Mar 7, 2024

OliverO2 commented Mar 7, 2024

Kantis commented Mar 8, 2024

OliverO2 commented Mar 8, 2024

Kantis commented Mar 8, 2024

OliverO2 commented Mar 8, 2024

OliverO2 commented Mar 11, 2024

sksamuel commented Mar 11, 2024

sksamuel Mar 11, 2024

OliverO2 Mar 11, 2024

OliverO2 Mar 11, 2024

sksamuel Mar 11, 2024

OliverO2 Mar 11, 2024

OliverO2 Mar 11, 2024

sksamuel Mar 11, 2024

OliverO2 Mar 11, 2024

ajalt Mar 11, 2024

		// The Kotlin compiler would insert test invocations here for kotlin-test.
		// This mechanism is not used with Kotest.

Add wasmJs target #3805

Add wasmJs target #3805

Conversation

OliverO2 commented Dec 13, 2023 • edited

OliverO2 commented Dec 15, 2023

OliverO2 commented Dec 16, 2023

eygraber commented Jan 17, 2024

OliverO2 commented Jan 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kantis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OliverO2 commented Mar 7, 2024

Kantis commented Mar 8, 2024

OliverO2 commented Mar 8, 2024

Kantis commented Mar 8, 2024

OliverO2 commented Mar 8, 2024

OliverO2 commented Mar 11, 2024

sksamuel commented Mar 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OliverO2 commented Dec 13, 2023 •

edited