Fix Arb.list failing within edge cases in case of null values

[oliverblaha]

This shall fix the issue as described in #3981.
Instead of just assuming that a null value means "there is no edge case", this change adds explicitly checking that, effectively fixing the problem.

[AlexCue987]

as the success here is "it doesn't throw an exception", should we say so: shouldNotThrowAny ...
also do we need to add any other checks for the output?

[oliverblaha]

shouldNoThrowAny sounds great. Don't think a check on the output adds any benefit though, but I'll give it another thought.

…

On Thu, Apr 25, 2024, 22:25 Alex Kuznetsov ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In kotest-property/src/jvmTest/kotlin/com/sksamuel/kotest/property/arbitrary/CollectionsTest.kt <#3982 (comment)>: > @@ -91,6 +92,11 @@ class CollectionsTest : DescribeSpec({ it.shouldHaveAtMostSize(500) } } + + it("not fail on edge cases for non-empty lists with null values") { as the success here is "it doesn't throw an exception", should we say so: shouldNotThrowAny ... also do we need to add any other checks for the output? — Reply to this email directly, view it on GitHub <#3982 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKAMQI3M45W7HC44R7G5K4TY7FRFJAVCNFSM6AAAAABGY4RSEGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRTGUYTAMRQGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[oliverblaha]

Updated: I've added some more scenarios and introduced some output checks.