feat: added SequencedSet for isOrderedSet #4002
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexCue987
reviewed
May 7, 2024
|
|
||
| /** | ||
| * JVM-specific: Allows TreeSet to be considered ordered for iterable comparisons | ||
| */ | ||
| actual fun isOrderedSet(item: Iterable<*>) = | ||
| item is LinkedHashSet || | ||
| item is SortedSet || | ||
| item is SequencedSet || |
There was a problem hiding this comment.
do we need to add/change any tests to validate this code change?
There was a problem hiding this comment.
do we need to add/change any tests to validate this code change?
well... for some java linkedHashSet I think so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding
SequencedSetinterface forisOrderedSetfinally fixing
#3848
and fix
#3996
working on test code for now