Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #1509

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

jorenham
Copy link

Also removed old python 3.6 code, and increased the upper bound of some deps

@jorenham
Copy link
Author

The CI seems to be complaining about issues irrelevant to this particular PR.

@jorenham
Copy link
Author

The failing tests can be replicated by checking out the master branch and a poetry update.

@koxudaxi
Copy link
Owner

koxudaxi commented Sep 7, 2023

@jorenham
Thank you for creating the PR.
Before we merge the PR. I want to check the active users of Python 3.7.
I understand the version is EOL. But I guess some projects may use the library in Python 3.7

@koxudaxi
Copy link
Owner

I have run the cli to get the activity of this month.
$ pypistats python_minor datamodel-code-generator -t -f markdown

category percent downloads
3.9 28.83% 123,761
null 23.56% 101,128
3.8 19.61% 84,168
3.10 11.75% 50,454
3.7 11.39% 48,904
3.11 4.84% 20,791
3.6 0.01% 56
3.3 0.00% 8
3.12 0.00% 3
Total 429,273

Date range: 2023-09-01 - 2023-09-24

@jorenham
Copy link
Author

@koxudaxi It's rather sad to see that there are more that twice the amount of 3.7 users than 3.11...

@koxudaxi
Copy link
Owner

@jorenham

@koxudaxi It's rather sad to see that there are more that twice the amount of 3.7 users than 3.11...

This is the real world😅

We should wait for pydantic itself to drop 3.7.
This is probably because pydantic is often used in the same project.
pydantic/pydantic#7188

@jorenham
Copy link
Author

@koxudaxi That makes sense. I'll try again in a couple of years then 😛

@jorenham
Copy link
Author

@koxudaxi pydantic/pydantic#7188 has been merged; time flies!

@@ -12,8 +12,6 @@


class PythonVersion(Enum):
PY_36 = '3.6'
PY_37 = '3.7'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorenham
I agree with you it's to drop support 3.7 from runtime support list.
Should we delete PY_37 for output?
Personally, I'm happy to drop the old version from the output model list.
But I want to think about it again. 🤔

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c298da5). Click here to learn what that means.

❗ Current head 65a1669 differs from pull request most recent head 8cbb3d5. Consider uploading reports for the commit 8cbb3d5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1509   +/-   ##
=======================================
  Coverage        ?   98.78%           
=======================================
  Files           ?       37           
  Lines           ?     4026           
  Branches        ?      938           
=======================================
  Hits            ?     3977           
  Misses          ?       36           
  Partials        ?       13           
Flag Coverage Δ
unittests 98.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koxudaxi
Copy link
Owner

$ pypistats python_minor datamodel-code-generator -t -f markdown

category percent downloads
3.9 28.87% 95,632
null 21.40% 70,884
3.8 18.20% 60,308
3.10 13.32% 44,143
3.7 9.83% 32,564
3.11 7.83% 25,935
3.12 0.53% 1,750
3.6 0.02% 67
3.3 0.01% 20
Total 331,303

Date range: 2023-11-01 - 2023-11-18

@koxudaxi
Copy link
Owner

koxudaxi commented Nov 20, 2023

0.24.* (2023/10/22~2023/11/21)
image

@koxudaxi
Copy link
Owner

koxudaxi commented Nov 20, 2023

0.23.* (2023/10/22~2023/11/21)
image

@koxudaxi koxudaxi mentioned this pull request Nov 21, 2023
Copy link

codspeed-hq bot commented Nov 21, 2023

CodSpeed Performance Report

Merging #1509 will not alter performance

Comparing jorenham:drop_py37 (8cbb3d5) with main (c298da5)

Summary

✅ 29 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants