New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.7 #1509
base: main
Are you sure you want to change the base?
Conversation
The CI seems to be complaining about issues irrelevant to this particular PR. |
The failing tests can be replicated by checking out the master branch and a |
@jorenham |
I have run the cli to get the activity of this month.
Date range: 2023-09-01 - 2023-09-24 |
@koxudaxi It's rather sad to see that there are more that twice the amount of 3.7 users than 3.11... |
This is the real world😅 We should wait for |
@koxudaxi That makes sense. I'll try again in a couple of years then 😛 |
@koxudaxi pydantic/pydantic#7188 has been merged; time flies! |
@@ -12,8 +12,6 @@ | |||
|
|||
|
|||
class PythonVersion(Enum): | |||
PY_36 = '3.6' | |||
PY_37 = '3.7' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorenham
I agree with you it's to drop support 3.7 from runtime support list.
Should we delete PY_37 for output?
Personally, I'm happy to drop the old version from the output model list.
But I want to think about it again. 🤔
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
=======================================
Coverage ? 98.78%
=======================================
Files ? 37
Lines ? 4026
Branches ? 938
=======================================
Hits ? 3977
Misses ? 36
Partials ? 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
$ pypistats python_minor datamodel-code-generator -t -f markdown
Date range: 2023-11-01 - 2023-11-18 |
CodSpeed Performance ReportMerging #1509 will not alter performanceComparing Summary
|
Also removed old python 3.6 code, and increased the upper bound of some deps