Ignore ResponseBody

kozaxinan · Aug 3, 2023 · ae4272e · ae4272e
1 parent c878f58
commit ae4272e
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/checks/src/main/java/com/kozaxinan/android/checks/RetrofitReturnTypeDetector.kt b/checks/src/main/java/com/kozaxinan/android/checks/RetrofitReturnTypeDetector.kt
@@ -62,6 +62,7 @@ internal abstract class RetrofitReturnTypeDetector : Detector(), UastScanner {
             val returnType = node.returnType
             return when {
                 node.isSuspend() -> findAllInnerFields(node.parameters.last().type as PsiClassType)
+                returnType is PsiClassType && returnType.isResponseBody() -> emptySet()
                 returnType is PsiClassType && returnType.isNotUnitOrVoid() ->
                     findAllInnerFields(returnType)
 
@@ -72,6 +73,8 @@ internal abstract class RetrofitReturnTypeDetector : Detector(), UastScanner {
         private fun PsiClassType.isNotUnitOrVoid() =
             !canonicalText.contains("Unit") && !canonicalText.contains("Void")
 
+        private fun PsiClassType.isResponseBody() = canonicalText.contains("ResponseBody")
+
         private fun hasRetrofitAnnotation(method: UMethod): Boolean {
             return context
                 .evaluator

diff --git a/...s/src/test/java/com/kozaxinan/android/checks/NetworkLayerClassImmutabilityDetectorTest.kt b/...s/src/test/java/com/kozaxinan/android/checks/NetworkLayerClassImmutabilityDetectorTest.kt
@@ -119,6 +119,32 @@ internal class NetworkLayerClassImmutabilityDetectorTest : LintDetectorTest() {
             .expectClean()
     }
 
+    @Test
+    fun `test kotlin file with RetrofitBody`() {
+        lint()
+            .files(
+                retrofit(),
+                rxjava(),
+                kotlin(
+                    """
+                package foo
+                
+                import io.reactivex.Completable
+                import retrofit2.http.GET
+                
+                interface Api {
+                
+                  @GET("url") 
+                  fun get(): ResponseBody
+                }
+                """.trimIndent()
+                )
+            )
+            .issues(ISSUE_NETWORK_LAYER_IMMUTABLE_CLASS_RULE)
+            .run()
+            .expectClean()
+    }
+
     @Test
     fun `test kotlin file with val and Parcelable`() {
         lint()