Add intial translation of the figures for the chapters of dynamic programming, greedy #1336

krahets · 2024-05-04T11:12:27Z

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

This PR represents the translation of a single, complete document, or contains only bug fixes.
The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

…gramming, greedy

krahets · 2024-05-04T12:10:57Z

Please review the translation based on the following aspects:

Ensure the expression is authentic and accurate.
Maintain consistency between the Chinese and English versions. (Balancing with point 1)
Since English is significantly longer than Chinese, some of the content has been simplified, resulting in poorer consistency. Please only add comments if you think it's ambiguous.

In addition to content, please pay attention to the format:

It is expected to use Roboto font for normal text and Roboto Mono for formulas and code. These may be prone to mistakes since they are set manually.
The style and color of shapes and texts should be consistent between the two versions. (I made some color adjustments in the EN version to enhance readability, so please only report those that feel uncomfortable to you.)

K3v123

overall looks good to me.
the texts are accurately translated. its just some colors and stuff. some text is grey in CN but different in EN. also bolds. etc

...hapter_dynamic_programming/dp_problem_features.assets/climbing_stairs_constraint_example.png

en/docs/chapter_dynamic_programming/dp_solution_pipeline.assets/min_path_sum_dfs.png

en/docs/chapter_dynamic_programming/dp_solution_pipeline.assets/min_path_sum_dp_step1.png

en/docs/chapter_dynamic_programming/dp_solution_pipeline.assets/min_path_sum_dp_step3.png

K3v123 · 2024-05-05T01:30:45Z

...r_dynamic_programming/dp_solution_pipeline.assets/min_path_sum_solution_state_definition.png

the word "grid" on EN is not grey.

Same comment as above, plus
I understand that the author wants to keep the words on the same line, but "Min path sum" is actually pretty confusing to many.
I'd suggest spelling everything out and changing it to "Minimize the sum of numbers on the path from the..."
Also, "Move one grid" is grammaly incorrect – it should've been "move by one grid"

Minimize the sum of numbers on the path from the...

https://leetcode.com/problems/minimum-path-sum/

Min path sum is the heading of the problem, so I believe it is not ambiguous, and it's clear to show the relationship between the original problem and the sub-problems.

en/docs/chapter_dynamic_programming/knapsack_problem.assets/knapsack_dp_comp_step1.png

en/docs/chapter_dynamic_programming/knapsack_problem.assets/knapsack_dp_comp_step2.png

en/docs/chapter_dynamic_programming/knapsack_problem.assets/knapsack_example.png

K3v123 · 2024-05-05T01:34:10Z

en/docs/chapter_greedy/fractional_knapsack_problem.assets/fractional_knapsack_example.png

Apple in EN while Banana in CN!!!!!

Besides the above, it should've been "the pineapple with weight = 30". "30 weight pineapple" is hard to read for native speakers.

en/docs/chapter_greedy/greedy_algorithm.assets/coin_change_greedy_vs_dp.png

yuelinxin

Great work! No substantial problem, plz consider the mentioned points.

...hapter_dynamic_programming/dp_problem_features.assets/climbing_stairs_constraint_example.png

yuelinxin · 2024-05-04T14:31:28Z

en/docs/chapter_dynamic_programming/dp_solution_pipeline.assets/min_path_sum_example.png

should the text alignment be centered in the text box?

Both terms are okay for me, although I personally prefer left-aligned English texts.

yuelinxin · 2024-05-05T16:35:46Z

en/docs/chapter_greedy/fractional_knapsack_problem.assets/fractional_knapsack_example.png

en/docs/chapter_greedy/max_product_cutting_problem.assets/max_product_cutting_greedy_infer1.png

frankliuao

Please see my comments. I didn't repeat my comment for all the pictures where I think 面值 should have been translated to "face value"

...hapter_dynamic_programming/dp_problem_features.assets/climbing_stairs_constraint_example.png

frankliuao · 2024-05-07T21:12:08Z

en/docs/chapter_dynamic_programming/dp_problem_features.assets/min_cost_cs_dp.png

"state transition equation" is grammarly correct but harder to understand.
"equation of state transition" is better.

I saw a relevant usage of "state transition equation" here, in the first section, point five.

"state-transition equation" has its dedicated meaning, background here:
https://en.wikipedia.org/wiki/State-transition_equation
Again it's grammarly correct, but harder to read.

@pengchzn @frankliuao

Fom GPT-4: In the context of dynamic programming, the term "state transition equation" is more commonly used and recognized. This term describes the mathematical expression or formula that defines how the state of a dynamic system changes from one state to another based on certain inputs or actions. The equation typically encapsulates how the current state and the decisions made influence the next state.

The phrase "equation of state transition" might convey a similar meaning, but it is less standard and might not be immediately recognized or understood in the field of dynamic programming or related disciplines like control theory and systems engineering.

en/docs/chapter_dynamic_programming/dp_problem_features.assets/min_cost_cs_example.png

en/docs/chapter_dynamic_programming/dp_solution_pipeline.assets/min_path_sum_dp_step1.png

en/docs/chapter_dynamic_programming/dp_solution_pipeline.assets/min_path_sum_dp_step12.png

en/docs/chapter_greedy/greedy_algorithm.assets/coin_change_greedy_strategy.png

en/docs/chapter_greedy/greedy_algorithm.assets/coin_change_greedy_vs_dp.png

en/docs/chapter_greedy/max_capacity_problem.assets/max_capacity_moving_long_board.png

en/docs/chapter_greedy/max_capacity_problem.assets/max_capacity_moving_short_board.png

en/docs/chapter_greedy/max_product_cutting_problem.assets/max_product_cutting_greedy_infer1.png

...hapter_dynamic_programming/dp_problem_features.assets/climbing_stairs_constraint_example.png

pengchzn · 2024-05-11T02:47:02Z

en/docs/chapter_dynamic_programming/dp_problem_features.assets/min_cost_cs_dp.png

I saw a relevant usage of "state transition equation" here, in the first section, point five.

...hapter_dynamic_programming/dp_problem_features.assets/climbing_stairs_constraint_example.png

en/docs/chapter_dynamic_programming/edit_distance_problem.assets/edit_distance_dp_step10.png

en/docs/chapter_dynamic_programming/edit_distance_problem.assets/edit_distance_dp_step2.png

en/docs/chapter_greedy/max_capacity_problem.assets/max_capacity_moving_short_board.png

en/docs/chapter_greedy/max_capacity_problem.assets/max_capacity_moving_long_board.png

pengchzn · 2024-05-11T04:22:13Z

en/docs/chapter_dynamic_programming/unbounded_knapsack_problem.assets/coin_change_dp_step1.png

I think "denomination" is correct as it says in the dictionary here

RafaelCaso

Frank did a good job of addressing the few concerns I had. Overall looks good. I understand these are captions, so the language needs to be short and direct. I focused on making sure they are consistent (which is the only feedback I gave)

krahets · 2024-05-31T07:58:13Z

Thanks for your thorough review! @frankliuao, @pengchzn, @yuelinxin, @K3v123, @RafaelCaso, most of the comments have been addressed.
A few comments remain unresolved for further discussion. Please let me know if there's anything else that needs fixing.

Add intial translation of the figures for the chapters of dynamic pro…

22bb934

…gramming, greedy

krahets added translation English translation documents documents-related labels May 4, 2024

krahets self-assigned this May 4, 2024

krahets changed the base branch from main to base May 4, 2024 11:15

krahets mentioned this pull request May 4, 2024

translation: Add intial translation of the figures for the rest of the chapters #1340

Merged

2 tasks

K3v123 reviewed May 5, 2024

View reviewed changes

yuelinxin reviewed May 7, 2024

View reviewed changes

frankliuao suggested changes May 10, 2024

View reviewed changes

pengchzn reviewed May 11, 2024

View reviewed changes

RafaelCaso approved these changes May 15, 2024

View reviewed changes

Update

d9eb2e7

krahets changed the base branch from base to main May 31, 2024 07:48

Merge branch 'main' into dev_trans4

a7a5007

krahets merged commit ae2ff7a into main May 31, 2024
1 check passed

krahets deleted the dev_trans4 branch May 31, 2024 07:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add intial translation of the figures for the chapters of dynamic programming, greedy #1336

Add intial translation of the figures for the chapters of dynamic programming, greedy #1336

krahets commented May 4, 2024

krahets commented May 4, 2024 •

edited

K3v123 left a comment

K3v123 May 5, 2024

frankliuao May 8, 2024

krahets May 31, 2024

K3v123 May 5, 2024

yuelinxin May 5, 2024

frankliuao May 10, 2024

yuelinxin left a comment

yuelinxin May 4, 2024

krahets May 31, 2024

yuelinxin May 5, 2024

frankliuao left a comment

frankliuao May 7, 2024

pengchzn May 11, 2024

frankliuao May 15, 2024

krahets May 31, 2024 •

edited

pengchzn May 11, 2024

pengchzn May 11, 2024

RafaelCaso left a comment

krahets commented May 31, 2024 •

edited

Add intial translation of the figures for the chapters of dynamic programming, greedy #1336

Add intial translation of the figures for the chapters of dynamic programming, greedy #1336

Conversation

krahets commented May 4, 2024

krahets commented May 4, 2024 • edited

K3v123 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuelinxin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frankliuao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krahets May 31, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RafaelCaso left a comment

Choose a reason for hiding this comment

krahets commented May 31, 2024 • edited

krahets commented May 4, 2024 •

edited

krahets May 31, 2024 •

edited

krahets commented May 31, 2024 •

edited