Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intial translation of the figures for the chapters of backtracking, divide and conquer, appendix #1337

Merged
merged 3 commits into from
May 31, 2024
Merged

Add intial translation of the figures for the chapters of backtracking, divide and conquer, appendix #1337

merged 3 commits into from
May 31, 2024

Conversation

krahets
Copy link
Owner

@krahets krahets commented May 4, 2024

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

  • This PR represents the translation of a single, complete document, or contains only bug fixes.
  • The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

@krahets krahets added translation English translation documents documents-related labels May 4, 2024
@krahets krahets self-assigned this May 4, 2024
@krahets krahets changed the base branch from main to base May 4, 2024 11:15
@krahets krahets mentioned this pull request May 4, 2024
Merged
2 tasks
@krahets
Copy link
Owner Author

krahets commented May 4, 2024 •
edited

Please review the translation based on the following aspects:

  1. Ensure the expression is authentic and accurate.
  2. Maintain consistency between the Chinese and English versions. (Balancing with point 1)
  3. Since English is significantly longer than Chinese, some of the content has been simplified, resulting in poorer consistency. Please only add comments if you think it's ambiguous.

In addition to content, please pay attention to the format:

  1. It is expected to use Roboto font for normal text and Roboto Mono for formulas and code. These may be prone to mistakes since they are set manually.
  2. The style and color of shapes and texts should be consistent between the two versions. (I made some color adjustments in the EN version to enhance readability, so please only report those that feel uncomfortable to you.)

K3v123
K3v123 reviewed May 5, 2024
View reviewed changes
Copy link
Contributor

@K3v123 K3v123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me.
there is one part that the bold and black text difference is a bit hard to be determined because of the style of text. and there is mismatch in colors in some other ones.

en/docs/chapter_backtracking/backtracking_algorithm.assets/preorder_find_constrained_paths.png Outdated Show resolved Hide resolved
en/docs/chapter_backtracking/n_queens_problem.assets/n_queens_constraints.png Show resolved Hide resolved
en/docs/chapter_backtracking/n_queens_problem.assets/n_queens_placing.png Outdated Show resolved Hide resolved
en/docs/chapter_backtracking/permutations_problem.assets/permutations_i_pruning.png Show resolved Hide resolved
en/docs/chapter_backtracking/permutations_problem.assets/permutations_i.png Outdated Show resolved Hide resolved
en/docs/chapter_backtracking/permutations_problem.assets/permutations_ii_pruning.png Show resolved Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_i_pruning.png Show resolved Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_ii.png Show resolved Hide resolved
en/docs/chapter_divide_and_conquer/hanota_problem.assets/hanota_divide_and_conquer.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure if its just me, the color grey and black is a bit hard to be determined compared to the text style from cn

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

”Subproblem f(1): ... to C“ -> ”Move remaining 1 disk from A to C“

Copy link
Owner Author

@krahets krahets May 31, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

”Subproblem f(1): ... to C“ -> ”Move remaining 1 disk from A to C“

No space for this 🤣

en/docs/chapter_divide_and_conquer/hanota_problem.assets/hanota_f3_step1.png Show resolved Hide resolved
pengchzn
pengchzn reviewed May 15, 2024
View reviewed changes
en/docs/chapter_backtracking/permutations_problem.assets/permutations_i_pruning.png Show resolved Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_i.png Show resolved Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_i_pruning.png Show resolved Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_ii.png Show resolved Hide resolved
en/docs/chapter_backtracking/subset_sum_problem.assets/subset_sum_ii.png Show resolved Hide resolved
en/docs/chapter_divide_and_conquer/hanota_problem.assets/hanota_divide_and_conquer.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

”Subproblem f(1): ... to C“ -> ”Move remaining 1 disk from A to C“

en/docs/chapter_divide_and_conquer/hanota_problem.assets/hanota_f3_step1.png Show resolved Hide resolved
yuelinxin
yuelinxin reviewed May 25, 2024
View reviewed changes
en/docs/chapter_backtracking/backtracking_algorithm.assets/backtrack_remove_return_or_not.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be better to replace "with" with a comma.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Record solution, then continue searching without returning

yuelinxin
yuelinxin reviewed May 26, 2024
View reviewed changes
Copy link
Contributor

@yuelinxin yuelinxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some wording and styling issues, but amazing work! Please consider my suggestions.

@krahets krahets changed the base branch from base to main May 31, 2024 07:59
@krahets
Copy link
Owner Author

krahets commented May 31, 2024

Thanks for your thorough review! @K3v123, @pengchzn, @yuelinxin, most of the comments have been addressed. A few comments remain unresolved for further discussion. Please let me know if there's anything else that needs fixing.

@krahets krahets merged commit 39a6890 into main May 31, 2024
1 check passed
@krahets krahets deleted the dev_trans3 branch May 31, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengchzn pengchzn pengchzn left review comments

@yuelinxin yuelinxin yuelinxin left review comments

@K3v123 K3v123 K3v123 left review comments

Assignees

@krahets krahets

Labels
documents documents-related translation English translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krahets @pengchzn @yuelinxin @K3v123