fix(Go): Update array_queue.go and array_deque.go #1362
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krahets
reviewed
May 31, 2024
codes/go/go.mod
Outdated
| @@ -1,3 +1,11 @@ | |||
| module github.com/krahets/hello-algo | |||
|
|
|||
| go 1.19 | |||
|
|
|||
| require ( | |||
| github.com/davecgh/go-spew v1.1.1 // indirect | |||
There was a problem hiding this comment.
Are these libs necessary?
The testify depends on this package go-spew
There was a problem hiding this comment.
We'd like to keep the third-party libraries as simple as possible, so I'd recommend remove them and the corresponding testing code.
There was a problem hiding this comment.
We'd like to keep the third-party libraries as simple as possible, so I'd recommend remove them and the corresponding testing code.
好的
krahets
reviewed
May 31, 2024
codes/go/go.sum
Outdated
| @@ -0,0 +1,10 @@ | |||
| github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= | |||
krahets
reviewed
May 31, 2024
krahets
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: