generate arginfo from stub #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add return type info for all functions add default values in reflection (PHP 8) drop support for PHP 7.1
stof
reviewed
Jan 6, 2022
| ZEND_FUNCTION(memory); | ||
|
|
||
|
|
||
| static const zend_function_entry ext_functions[] = { |
There was a problem hiding this comment.
why ext_functions and not something with pcov in the name ?
There was a problem hiding this comment.
why
ext_functionsand not something withpcovin the name ?
This file is generated ;)
So, a PHP choice, not under control of this extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add return type info for all functions
add default values in reflection (PHP 8)
drop support for PHP 7.1
Probably worth to bump version to 1.1.0-dev