feat: Add support for build-secrets #604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanuel-skrenkovic
force-pushed
the
feature/build-secrets
branch
2 times, most recently
from
3be58c4
to
824e9b1
Compare
Enables passing of build-secrets through the 'secrets' block inside 'build'. The feature is only available when using Buildkit.
emanuel-skrenkovic
force-pushed
the
feature/build-secrets
branch
from
824e9b1
to
10c45ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables passing of build-secrets through the 'secrets' block inside 'build'.
The feature is only available when using Buildkit.
I don't have much knowledge as to how build secrets work, but I tried to follow how buildx does it and implement it here. This feature is something that pops up as a need often at my job.
If changes need to be made, I will try to accommodate. :)
Tested by installing the provider locally, pushing the secrets into files in the Dockerfile, and verifying that the values were passed through.