refac(halo2): change concrete struct type to trait type for rng #394
+24
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
changed the title
|
Thanks for your contribution! 🎉 Firstly, could you please follow the commit convention outlined here? Additionally, it's essential that every commit is buildable and testable, but unfortunately, your PR doesn't meet these criteria. To address this, I suggest squashing all the commits into a single one to ensure they're buildable and testable. Let me know if you have any questions or need further clarification. Thanks again for your effort! 👍 |
chokobole
reviewed
Apr 23, 2024
k-gunjan
force-pushed
the
refac/change-concrete-struct-type-to-trait-type-for-rng
branch
from
1ded7a6
to
fc029f6
Compare
…iftRng with generic R which implements RngState
k-gunjan
force-pushed
the
refac/change-concrete-struct-type-to-trait-type-for-rng
branch
from
fc029f6
to
28a22d5
Compare
chokobole
reviewed
Apr 24, 2024
chokobole
changed the title
|
@k-gunjan |
ashjeong
reviewed
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes rng parameter of create_proof function generic over RngCore and RngState.
Defined trait RngState and implemented for XORShiftRng