refac: generalize example circuit tests #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashjeong
requested review from
chokobole,
dongchangYoo,
Insun35 and
TomTaehoonKim
ashjeong
force-pushed
the
refac/generalize-example-circuit-tests
branch
from
5896a33
to
70b8875
Compare
chokobole
reviewed
May 10, 2024
|
I think both of them should be test scope! |
ashjeong
commented
May 10, 2024
ashjeong
force-pushed
the
refac/generalize-example-circuit-tests
branch
8 times, most recently
from
cb239a9
to
d26427a
Compare
ashjeong
force-pushed
the
refac/generalize-example-circuit-tests
branch
from
d26427a
to
f0d9863
Compare
ashjeong
force-pushed
the
refac/generalize-example-circuit-tests
branch
from
f0d9863
to
52d8f81
Compare
dongchangYoo
requested changes
May 14, 2024
ashjeong
force-pushed
the
refac/generalize-example-circuit-tests
branch
from
52d8f81
to
92ed4c6
Compare
ashjeong
force-pushed
the
refac/generalize-example-circuit-tests
branch
from
92ed4c6
to
5710537
Compare
TomTaehoonKim
requested changes
May 14, 2024
dongchangYoo
requested changes
May 16, 2024
|
If there is no intention to separate |
dongchangYoo
requested changes
May 16, 2024
ashjeong
force-pushed
the
refac/generalize-example-circuit-tests
branch
from
5710537
to
1ac87b4
Compare
chokobole
requested changes
May 16, 2024
ashjeong
force-pushed
the
refac/generalize-example-circuit-tests
branch
2 times, most recently
from
6aee1c7
to
c46985f
Compare
Insun35
reviewed
May 16, 2024
chokobole
reviewed
May 16, 2024
ashjeong
force-pushed
the
refac/generalize-example-circuit-tests
branch
from
c46985f
to
cb28fd8
Compare
Note that the GWC verison is not currently run as a test as all of the data is not currently available
ashjeong
force-pushed
the
refac/generalize-example-circuit-tests
branch
from
cb28fd8
to
1e59bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR...
SimpleCircuit,SimpleLookupCircuit, andShuffleCircuithave been generalized into a single test fileNote: More testing/test data should be added in the future for more in-depth testing. Refer to
tracking_testing.mdfor more information.