YAML Test Suite tests #59

aSemy · 2023-06-10T08:57:38Z

TODO

use the file-based test data, not the YAML-based data (which requires parsing and is not well documented)
IntelliJ doesn't seem to support EditorConfig very well any more. I propose committing .idea/codeStyles/codeStyleConfig.xml to the repo in a separate PR. Commit IJ codestyle files #64
split off some of the code tidying/refactoring into a separate PR

Updating `MappingNode` to be immutable makes the code more Kotlin-esque Change split off from #59

krzema12 · 2023-09-07T12:41:41Z

@aSemy this PR looks like it contains several kinds of changes that are not really related. It would be much easier for me to review and check for correctness if we split it into e. g.:

kotlinizing code
fixing code
running tests from the YAML test suite

aSemy · 2023-09-13T07:17:00Z

@aSemy this PR looks like it contains several kinds of changes that are not really related. It would be much easier for me to review and check for correctness if we split it into e. g.:

kotlinizing code

fixing code

running tests from the YAML test suite

Agreed, I'll split them out.

- remove unused functions - avoid using `!!` to force non-null - update Parse to have multiplatform constructor - add/adjust docs and docs formatting - avoid using scope functions for simple checks (scope functions tend to be more difficult to read) - refactor environment variable fetching (improve legibility, and prepare for multiplatform testing) - use sealed classes where possible (because the classes are not intended to be extended by external libraries) - convert `NodeTuple` to regular class (data classes ABI is more difficult to maintain) - re-write while-loops to avoid awkward scope functions and variable assignments

code and docs tidying, in preparation for YAML Test Suites #59 - remove unused `toBigDecimal` function - avoid using `!!` to force non-null - update Parse to have multiplatform constructor - add/adjust docs and docs formatting - avoid using scope functions for simple checks (scope functions tend to be more difficult to read) - refactor environment variable fetching (improve legibility, and prepare for multiplatform testing) - use sealed classes where possible (because the classes are not intended to be extended by external libraries) - convert `NodeTuple` to regular class (data classes ABI is more difficult to maintain) - re-write while-loops to avoid awkward scope functions and variable assignments - Replace custom `StreamDataWriter` in test with existing `StringStreamDataWriter`

build.gradle.kts

src/jvmTest/java/org/snakeyaml/engine/usecases/fuzzy/FuzzYAMLRead56902Test.java

buildSrc/src/main/kotlin/buildsrc/conventions/yaml-testing.gradle.kts

buildSrc/src/main/kotlin/buildsrc/tasks/GenerateYamlTestSuiteData.kt

src/commonMain/kotlin/org/snakeyaml/engine/v2/exceptions/MarkedYamlEngineException.kt

src/commonTest/kotlin/org/snakeyaml/engine/test_suite/SuiteUtils.kt

…no events' and 'error'

…yaml_test_suite

krzema12 · 2023-09-14T19:22:35Z

Thanks! 🙇

aSemy force-pushed the feat/yaml_test_suite branch from 950016f to 9c03fde Compare June 10, 2023 08:58

aSemy mentioned this pull request Jun 10, 2023

Update MappingNode.value to be immutable #60

Merged

aSemy added a commit that referenced this pull request Jun 11, 2023

Update MappingNode.value to be immutable (#60)

9f9b83b

Updating `MappingNode` to be immutable makes the code more Kotlin-esque Change split off from #59

aSemy force-pushed the feat/yaml_test_suite branch from ba1b5ef to 1cdf9fb Compare June 15, 2023 10:39

aSemy mentioned this pull request Aug 29, 2023

Add Kotlin Native targets charleskorn/kaml#458

Closed

aSemy marked this pull request as ready for review September 4, 2023 10:37

aSemy requested a review from krzema12 September 4, 2023 10:37

aSemy mentioned this pull request Sep 4, 2023

move resources to commonTest, in preparation for more multiplatform tests #51

Closed

aSemy added 14 commits September 13, 2023 11:18

create Gradle task to download YAML test data

b540707

implement YAML test suite tests, and fix/tidy code

99f7a82

implement YAML test suite tests, and fix/tidy code

60358c6

formatting

e2bb621

update YAML Test Suite data to use file-based data

ec7388c

rename singleNode() -> getSingleNode() (prep for #66)

d7cc5aa

verify ignored YAML Test Suite fail/pass

74102a8

tidy up StandardConstructor

a8c944c

tidy up Emitter

aeec3d1

code & kdoc tidying, removing scope functions

439bfb1

tidy up code, add comments, remove unused repo

72dd258

minor code tidy (map {}.toSet() is less efficient, but more readable)

f065dcc

fix rebase merge conflicts

bd0676c

aSemy force-pushed the feat/yaml_test_suite branch from 3d83c83 to bd0676c Compare September 13, 2023 09:30

aSemy marked this pull request as draft September 13, 2023 09:30

aSemy changed the base branch from main to feat/kotlinize-code September 13, 2023 09:31

aSemy mentioned this pull request Sep 13, 2023

Kotlin code improvements #91

Merged

Base automatically changed from feat/kotlinize-code to main September 13, 2023 11:21

aSemy added 4 commits September 13, 2023 13:53

Merge remote-tracking branch 'origin/main' into feat/yaml_test_suite

2c035ea

Tidy GenerateYamlTestSuiteData

2299e81

remove unnecessary 'mustRunAfter'

300b8c7

update Yarn lock

8543cf9

aSemy marked this pull request as ready for review September 13, 2023 12:04

aSemy commented Sep 13, 2023

View reviewed changes

build.gradle.kts Show resolved Hide resolved

aSemy added 2 commits September 13, 2023 14:05

remove jvmToolchain(11) (should be done in a separate PR)

bec7c06

remove unused dropDirectoriesWhile() util

5de8314

aSemy commented Sep 13, 2023

View reviewed changes

src/jvmTest/java/org/snakeyaml/engine/usecases/fuzzy/FuzzYAMLRead56902Test.java Show resolved Hide resolved

aSemy added 2 commits September 13, 2023 14:12

minor code tidying

277d09e

recreate yarn lock, again

44b2b05

krzema12 reviewed Sep 14, 2023

View reviewed changes

src/commonTest/kotlin/org/snakeyaml/engine/test_suite/SuiteUtils.kt Show resolved Hide resolved

aSemy added 4 commits September 14, 2023 12:48

undo unrelated issue link change

d2e77a3

Add additional comments

0d7f01c

change ParseResult.events to be nullable, to discriminate between '…

21a720c

…no events' and 'error'

Merge remote-tracking branch 'origin/feat/yaml_test_suite' into feat/…

a3a9ac8

…yaml_test_suite

krzema12 approved these changes Sep 14, 2023

View reviewed changes

aSemy merged commit 043626d into main Sep 14, 2023
4 checks passed

aSemy deleted the feat/yaml_test_suite branch September 14, 2023 21:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YAML Test Suite tests #59

YAML Test Suite tests #59

aSemy commented Jun 10, 2023 •

edited

krzema12 commented Sep 7, 2023

aSemy commented Sep 13, 2023

krzema12 commented Sep 14, 2023

YAML Test Suite tests #59

YAML Test Suite tests #59

Conversation

aSemy commented Jun 10, 2023 • edited

TODO

krzema12 commented Sep 7, 2023

aSemy commented Sep 13, 2023

krzema12 commented Sep 14, 2023

aSemy commented Jun 10, 2023 •

edited