Use BlockCipher.blockSize as a result length in randomIV helper #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help to avoid two mistakes when `randomIV` helper is used: * Passing of invalid array length for IV generation * Usage of this method for key generation
|
@krzyzanowskim any feedback for this? |
| public extension Cryptors where Self: BlockCipher { | ||
| /// Generates array of random bytes. `blockSize` is used as length of the result array. | ||
| /// Convenience helper that uses `Swift.SystemRandomNumberGenerator`. | ||
| static func randomIV() -> [UInt8] { |
There was a problem hiding this comment.
can it be randomIV(_ count: Int = Self.blockSize) ?
There was a problem hiding this comment.
It can, but then it defeats the purpose of these changes. I'd like to make this helper hard to use in a wrong way.
There was a problem hiding this comment.
It's not, really. It keep the backward compatibility, while use the blockSize default now
There was a problem hiding this comment.
Well, I've returned randomIV(_ count: Int) helper marking it as deprecated, so existing code won't be broken after upgrade to the new version
Repository owner
deleted a comment
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Changes proposed in this pull request:
Use
BlockCipher.blockSizeas a result length inrandomIVhelper. This should help to avoid two mistakes whenrandomIVhelper is used:randomIVhelper for a key generation. Because it usesSwift.SystemRandomNumberGenerator, depending on the platform the result might be not cryptographically secure to be used as a key.Security.SecRandomCopyBytesshould be preferred to generate a key on Apple platforms.