Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrading the required Qt5 version to be compatible with CentOS-7 provided version #929

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

truatpasteurdotfr
Copy link

one line diff for the rpm linux target only to keep the CentOS-7 users happy...

@DamirPorobic
Copy link
Member

I think the 5.12 was also piked in this case was to have a consistent Qt version across our binaries. Downgrading it here to 5.9.7 again would mean that our rpms run with 5.9.7 and all other binaries with 5.12. I'm not sure that this is a good idea to be honest.

Also, the rpm will be discontinued with the next minor release so we should be looking for alternatives for you here. Does the AppImage work for you or do you have the same problem with dependencies?

@truatpasteurdotfr
Copy link
Author

truatpasteurdotfr commented Nov 20, 2022

Appimage requires each user to install a 30 MB file, whereas rpm provide a consistent shared resources for all our users across all our machines of ~6 MB...

Finally the official 1.10.0 appimage is not working on CentOS-7:

[tru@elitebook840g3 Downloads]$ ./ksnip-1.10.0-x86_64.AppImage
./ksnip-1.10.0-x86_64.AppImage: /lib64/libc.so.6: version `GLIBC_2.27' not found (required by /tmp/.mount_ksnip-UXBGGd/usr/bin/../lib/libgssapi_krb5.so.2)
./ksnip-1.10.0-x86_64.AppImage: /lib64/libc.so.6: version `GLIBC_2.25' not found (required by /tmp/.mount_ksnip-UXBGGd/usr/bin/../lib/libsystemd.so.0)
./ksnip-1.10.0-x86_64.AppImage: /lib64/libc.so.6: version `GLIBC_2.27' not found (required by /tmp/.mount_ksnip-UXBGGd/usr/bin/../lib/libsystemd.so.0)
./ksnip-1.10.0-x86_64.AppImage: /lib64/libgpg-error.so.0: no version information available (required by /tmp/.mount_ksnip-UXBGGd/usr/bin/../lib/libgcrypt.so.20)
[tru@elitebook840g3 Downloads]$ rpm -q glibc
glibc-2.17-326.el7_9.x86_64
glibc-2.17-326.el7_9.i686

@@ -1,6 +1,7 @@
name: linux

on:
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added that, just to be able to manually enable the CI.

@DamirPorobic
Copy link
Member

I see. Ok, as CentOS has such a long support, let's do this but after 1.11.0 there will be no rpm anymore, you are probably going to stuck with 1.10.X

@truatpasteurdotfr
Copy link
Author

Thanks for considering that request! ksnip 1.10.x and with only bug fix is perfect as C7 eol is june 2024 https://wiki.centos.org/About/Product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants