Objections to changing boundary to internal on MultiPartFormDataContent?

[jschneidereit]

ktor/ktor-client/ktor-client-core/common/src/io/ktor/client/request/forms/FormDataContent.kt

Line 43 in 3ce3906

private val boundary: String = generateBoundary()

I'd like to change this to internal so I can consume the boundary like so:

class MultiPartMixedDataContent(
        parts: List<PartData>
) : MultiPartFormDataContent {
    override val contentType: ContentType = ContentType.MultiPart.Mixed.withParameter("boundary", boundary)
}

[e5l]

Hi @jschneidereit, thanks for the report.
It's the valid use case and we're absolutely OK to change that. I think it should be protected to fit your case.

It would be nice if you make the PR :)

[jschneidereit]

@e5l - Change is in progress and it looks like I'd have to make MultiPartFormDataContent open, is that acceptable?

[e5l]

That's OK

[jschneidereit]

Hey @e5l could I get a review on the linked PR? I saw in contributing that there were documentation changes required but am not sure what changes I should make since they'll be picked up by intellisense 🤔

[cy6erGn0m]

Using inheritance for extending is generally not the best option and usually causes difficulties due to inheritance and instantiation limitations. I would prefer adding a constructor parameter with the default argument computing by the generate function. So one could simply pass a custom value if required.

[jschneidereit]

@cy6erGn0m how about my solution in #2003?

[oleg-larshin]

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.