New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1970 - update MultiPartFormDataContent to allow contentType override using optional builder #2003
Conversation
ktor-client/ktor-client-core/common/src/io/ktor/client/request/forms/FormDataContent.kt
Outdated
Show resolved
Hide resolved
Hey @jschneidereit, sorry for the delay. Could you check one thing before the merge? |
@e5l did I miss something? |
/** | ||
* [OutgoingContent] for multipart/form-data formatted request. | ||
* | ||
* @param parts: form part data | ||
*/ | ||
public class MultiPartFormDataContent( | ||
parts: List<PartData> | ||
parts: List<PartData>, | ||
val boundary: String = generateBoundary(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you tell me why do we need boundary
in the constructor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @e5l I had originally made it override-able but @cy6erGn0m requested an optional constructor argument in the discussion in #1970
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other option to only having contentType
in the constructor and not boundary
would be a lambda that accepts a string like contentTypeFn: (String) -> ContentType
but I think that's a little overkill.
Fixes #1970
Subsystem
Client
Motivation
Before this change
MultiPartFormDataContent
was not compatible with servers that acceptedmultipart/mixed
content.Solution
Now a user can pass their own lambda for building content type like so: