Update Dokka to 1.9.0 and add a workaround for build errors #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a workaround for running Dokka with Gradle 8 and Kotlin 1.9.0; otherwise it leads to build errors related to platform dependency resolution For more details, see Kotlin/dokka#3153
|
Note: because ktor has many nested modules, you need to run Dokka's multimodule task with a semicolon (i.e only on the root project): I've sent a fix for the publishing script and explained it in more detail there, see ktorio/api.ktor.io#11 |
rsinukov
approved these changes
Oct 23, 2023
marychatte
pushed a commit
that referenced
this pull request
Nov 10, 2023
Adds a workaround for running Dokka with Gradle 8 and Kotlin 1.9.0; otherwise it leads to build errors related to platform dependency resolution For more details, see Kotlin/dokka#3153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Infrastructure
Motivation
Dokka stopped working after #3662 was merged into
main. If you run Dokka's tasks now, it will lead to build failures related to the resolution of platform dependencies, likely caused by the combination of Gradle 8 +kotlin.mpp.enableCInteropCommonization=trueSolution
Update Dokka to 1.9.0 and use the proposed workaround flag, which changes the underlying dependency resolution algorithm.
For more details, see Kotlin/dokka#3153.