Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support multi-doc kubeconfigs - fixes #440 #441

Merged
merged 3 commits into from Feb 28, 2021
Merged

support multi-doc kubeconfigs - fixes #440 #441

merged 3 commits into from Feb 28, 2021

Conversation

clux
Copy link
Member

@clux clux commented Feb 27, 2021 •
edited

  • support for multiple documents in a single file
  • unit tests for it
  • document kubeconfig better

@clux clux linked an issue Feb 27, 2021 that may be closed by this pull request
support kubeconfigs with more than one document #440
Closed
kazk
kazk approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@kazk kazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I've fixed the warnings under "Unchanged files with check annotations" in #442. I guess that only works when you open the PR?

@clux
Copy link
Member Author

clux commented Feb 28, 2021 •
edited

I've fixed the warnings under "Unchanged files with check annotations" in #442. I guess that only works when you open the PR?

Ah, that's because you probably pushed from a fork at the time.
See https://github.com/actions-rs/clippy-check#limitations

It's not great, but at least you have write access to push branches.

@clux clux merged commit 0882a6f into master Feb 28, 2021
@clux clux deleted the multi-file-config branch February 28, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazk kazk kazk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support kubeconfigs with more than one document
2 participants
@clux @kazk