Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the kubeedge api file to the staging directory #5472

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wbc6080
Copy link
Contributor

@wbc6080 wbc6080 commented Mar 16, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Copy the kubeedge api file to the staging directory,and prepare for the subsequent establishment of kubeedge api repo(kubeedge/community#193)
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: wbc6080 <wangbincheng4@huawei.com>
@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 16, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 16, 2024
Signed-off-by: wbc6080 <wangbincheng4@huawei.com>
@WillardHu
Copy link
Collaborator

Do we need to rename the stage project staging/src/github.com/kubeedge/api, like staging/src/github.com/kubeedge-api? Do we also need to map this folder to a github project?

@wbc6080
Copy link
Contributor Author

wbc6080 commented May 9, 2024

Do we need to rename the stage project staging/src/github.com/kubeedge/api, like staging/src/github.com/kubeedge-api? Do we also need to map this folder to a github project?

Here I refer to the naming method of the api in the staging directory like in kubernetes https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/api, which is directly called the api library. After this PR is merged, an api repo needs to be created, and the code will be synchronized from the staging directory to the api repo. In addition, I have also submitted an application for building the new api repo kubeedge/community#193. @WillardHu

@WillardHu
Copy link
Collaborator

WillardHu commented May 9, 2024

Here I refer to the naming method of the api in the staging directory like in kubernetes https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/api, which is directly called the api library. After this PR is merged, an api repo needs to be created, and the code will be synchronized from the staging directory to the api repo. In addition, I have also submitted an application for building the new api repo kubeedge/community#193. @WillardHu

Ok, I thought this directory github.com/kubeedge was new, but actually this directory is the parent directory of all subprojects.

@WillardHu
Copy link
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants