Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Remove PipelineSpec Template storage from ObjStore responsibilies. Fixes #10509 #10790

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gmfrasca
Copy link
Member

@gmfrasca gmfrasca commented May 6, 2024

Description of your changes:
Fixes #10509

The PipelineSpec definition is currently stored in two places, DB and ObjStore, creating the potential for a competing source-of-truth problem. The ObjStore copy doesn't appear to actually be used/retrieved anywhere, so remove it from the list of responsibilities

Checklist:

…ponsibilies. Fixes kubeflow#10509

Signed-off-by: Giulio Frasca <gfrasca@redhat.com>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK
Copy link
Contributor

HumairAK commented May 9, 2024

/test kubeflow-pipeline-backend-test

Copy link

@gmfrasca: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-upgrade-test 84ebbf7 link false /test kubeflow-pipeline-upgrade-test
kubeflow-pipeline-e2e-test 84ebbf7 link false /test kubeflow-pipeline-e2e-test
kubeflow-pipeline-backend-test 84ebbf7 link true /test kubeflow-pipeline-backend-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Store Pipeline IR in database, not object storage
2 participants